Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: media/mojo/services/BUILD.gn

Issue 2581893002: Use the /WX flag to have link warnings treated as errors. (Closed)
Patch Set: Restore exceptions and update comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/win/BUILD.gn ('K') | « media/mojo/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/BUILD.gn
diff --git a/media/mojo/services/BUILD.gn b/media/mojo/services/BUILD.gn
index f64a5e1f0f8f4cd1c1c3275e5ec570e69b795677..3ee32122d8a77b323f362178a09b65a4ce6b0811 100644
--- a/media/mojo/services/BUILD.gn
+++ b/media/mojo/services/BUILD.gn
@@ -132,6 +132,11 @@ source_set("lib") {
service("media") {
testonly = true
+ # crbug.com/676418: Suppress symbol import warnings.
+ if (is_win && is_component_build) {
+ ldflags = [ "/ignore:4217" ]
+ }
+
sources = [
"main.cc",
]
« build/config/win/BUILD.gn ('K') | « media/mojo/BUILD.gn ('k') | third_party/WebKit/Source/platform/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698