Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: third_party/WebKit/Source/platform/BUILD.gn

Issue 2581893002: Use the /WX flag to have link warnings treated as errors. (Closed)
Patch Set: Restore exceptions and update comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« build/config/win/BUILD.gn ('K') | « media/mojo/services/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//testing/libfuzzer/fuzzer_test.gni") 7 import("//testing/libfuzzer/fuzzer_test.gni")
8 import("//testing/test.gni") 8 import("//testing/test.gni")
9 import("//third_party/WebKit/public/public_features.gni") 9 import("//third_party/WebKit/public/public_features.gni")
10 import("//third_party/WebKit/Source/build/scripts/scripts.gni") 10 import("//third_party/WebKit/Source/build/scripts/scripts.gni")
(...skipping 1496 matching lines...) Expand 10 before | Expand all | Expand 10 after
1507 "clipboard/ClipboardUtilitiesPosix.cpp", 1507 "clipboard/ClipboardUtilitiesPosix.cpp",
1508 1508
1509 # Uses LocaleWin instead. 1509 # Uses LocaleWin instead.
1510 "text/LocaleICU.cpp", 1510 "text/LocaleICU.cpp",
1511 "text/LocaleICU.h", 1511 "text/LocaleICU.h",
1512 ] 1512 ]
1513 cflags = [ 1513 cflags = [
1514 "/wd4334", # Result of 32-bit shift implicitly converted to 64 bits. 1514 "/wd4334", # Result of 32-bit shift implicitly converted to 64 bits.
1515 "/wd4724", # Modulo by 0. 1515 "/wd4724", # Modulo by 0.
1516 ] 1516 ]
1517
1518 # crbug.com/654776: Suppress symbol import warnings.
1519 if (is_component_build) {
1520 ldflags = [
1521 "/ignore:4217",
1522 "/ignore:4049",
1523 ]
1524 }
1517 } else { 1525 } else {
1518 sources -= [ 1526 sources -= [
1519 "clipboard/ClipboardUtilitiesWin.cpp", 1527 "clipboard/ClipboardUtilitiesWin.cpp",
1520 "text/LocaleWin.cpp", 1528 "text/LocaleWin.cpp",
1521 ] 1529 ]
1522 } 1530 }
1523 1531
1524 if (is_android) { 1532 if (is_android) {
1525 # Add in some Linux files also shared with Android. 1533 # Add in some Linux files also shared with Android.
1526 set_sources_assignment_filter([]) 1534 set_sources_assignment_filter([])
(...skipping 543 matching lines...) Expand 10 before | Expand all | Expand 10 after
2070 "//third_party/WebKit/Source:config", 2078 "//third_party/WebKit/Source:config",
2071 "//third_party/WebKit/Source:inside_blink", 2079 "//third_party/WebKit/Source:inside_blink",
2072 ] 2080 ]
2073 2081
2074 deps = [ 2082 deps = [
2075 ":test_support", 2083 ":test_support",
2076 "//testing/gmock", 2084 "//testing/gmock",
2077 "//testing/gtest", 2085 "//testing/gtest",
2078 ] 2086 ]
2079 } 2087 }
OLDNEW
« build/config/win/BUILD.gn ('K') | « media/mojo/services/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698