Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h

Issue 2581843002: Implement merging non-composited paint property nodes in the PACompositor. (Closed)
Patch Set: none Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h b/third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h
index e86f72bc2c0a9a42220c7678c5cb2946ffd139bb..80ec78512f99d66e0b5eeca8236732157745920f 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/ClipPaintPropertyNode.h
@@ -31,9 +31,11 @@ class PLATFORM_EXPORT ClipPaintPropertyNode
static PassRefPtr<ClipPaintPropertyNode> create(
PassRefPtr<const ClipPaintPropertyNode> parent,
PassRefPtr<const TransformPaintPropertyNode> localTransformSpace,
- const FloatRoundedRect& clipRect) {
+ const FloatRoundedRect& clipRect,
+ CompositingReasons directCompositingReasons = CompositingReasonNone) {
return adoptRef(new ClipPaintPropertyNode(
- std::move(parent), std::move(localTransformSpace), clipRect));
+ std::move(parent), std::move(localTransformSpace), clipRect,
+ directCompositingReasons));
}
void update(PassRefPtr<const ClipPaintPropertyNode> parent,
@@ -59,8 +61,9 @@ class PLATFORM_EXPORT ClipPaintPropertyNode
// The clone function is used by FindPropertiesNeedingUpdate.h for recording
// a clip node before it has been updated, to later detect changes.
PassRefPtr<ClipPaintPropertyNode> clone() const {
- return adoptRef(
- new ClipPaintPropertyNode(m_parent, m_localTransformSpace, m_clipRect));
+ return adoptRef(new ClipPaintPropertyNode(m_parent, m_localTransformSpace,
+ m_clipRect,
+ m_directCompositingReasons));
}
// The equality operator is used by FindPropertiesNeedingUpdate.h for checking
@@ -74,18 +77,25 @@ class PLATFORM_EXPORT ClipPaintPropertyNode
String toString() const;
+ bool hasDirectCompositingReasons() const {
+ return m_directCompositingReasons != CompositingReasonNone;
+ }
+
private:
ClipPaintPropertyNode(
PassRefPtr<const ClipPaintPropertyNode> parent,
PassRefPtr<const TransformPaintPropertyNode> localTransformSpace,
- const FloatRoundedRect& clipRect)
+ const FloatRoundedRect& clipRect,
+ CompositingReasons directCompositingReasons)
: m_parent(parent),
m_localTransformSpace(localTransformSpace),
- m_clipRect(clipRect) {}
+ m_clipRect(clipRect),
+ m_directCompositingReasons(directCompositingReasons) {}
RefPtr<const ClipPaintPropertyNode> m_parent;
RefPtr<const TransformPaintPropertyNode> m_localTransformSpace;
FloatRoundedRect m_clipRect;
+ CompositingReasons m_directCompositingReasons;
};
// Redeclared here to avoid ODR issues.

Powered by Google App Engine
This is Rietveld 408576698