Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: tests/RecordDrawTest.cpp

Issue 258183002: Don't bother doing the empty clip check in SkRecordDraw. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: comments and tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/record/SkRecordDraw.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/RecordDrawTest.cpp
diff --git a/tests/RecordDrawTest.cpp b/tests/RecordDrawTest.cpp
index 8c6635489e16f61e1ac3bbc40266bc43cfd380ab..c4dab84273bcecb926a2fdbed04c12afdc727d50 100644
--- a/tests/RecordDrawTest.cpp
+++ b/tests/RecordDrawTest.cpp
@@ -45,27 +45,3 @@ DEF_TEST(RecordDraw_Culling, r) {
// If culling weren't working, we'd see 8 commands recorded here.
REPORTER_ASSERT(r, 5 == rerecord.count());
}
-
-DEF_TEST(RecordDraw_Clipping, r) {
- SkRecord record;
- SkRecorder recorder(SkRecorder::kWriteOnly_Mode, &record, W, H);
-
- // 8 draw commands.
- recorder.save();
- recorder.clipRect(SkRect::MakeLTRB(0, 0, 100, 100));
- recorder.drawRect(SkRect::MakeLTRB(20, 20, 40, 40), SkPaint());
- recorder.save();
- // This clipRect makes the clip empty, so the next command does nothing.
- recorder.clipRect(SkRect::MakeLTRB(200, 200, 300, 300));
- recorder.drawRect(SkRect::MakeLTRB(220, 220, 240, 240), SkPaint()); // Skipped
- recorder.restore();
- recorder.restore();
-
- // Same deal as above: we need full SkCanvas semantics for clip skipping to work.
- SkRecord rerecord;
- SkRecorder rerecorder(SkRecorder::kReadWrite_Mode, &rerecord, W, H);
- SkRecordDraw(record, &rerecorder);
-
- // All commands except the one marked // Skipped will be preserved.
- REPORTER_ASSERT(r, 7 == rerecord.count());
-}
« no previous file with comments | « src/record/SkRecordDraw.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698