Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2581803002: Add access to FutureOr in TypeProviders (and add implementation in mock sdks) (Closed)

Created:
4 years ago by Brian Wilkerson
Modified:
4 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, Bob Nystrom
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add access to FutureOr in TypeProviders (and add implementation in mock sdks) R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/cfcfe7a5cf0286fc3db24213739b1fff56255e99

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -0 lines) Patch
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 4 chunks +14 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/test_type_provider.dart View 2 chunks +25 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 2 chunks +5 lines, -0 lines 2 comments Download
M pkg/analyzer/lib/src/summary/summary_sdk.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
First small step toward providing support.
4 years ago (2016-12-15 20:45:31 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2581803002/diff/1/pkg/analyzer/lib/src/summary/link.dart File pkg/analyzer/lib/src/summary/link.dart (right): https://codereview.chromium.org/2581803002/diff/1/pkg/analyzer/lib/src/summary/link.dart#newcode4710 pkg/analyzer/lib/src/summary/link.dart:4710: _futureOrType ??= _buildInterfaceType(_linker.asyncLibrary, 'Future'); 'FutureOr'?
4 years ago (2016-12-15 20:47:58 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2581803002/diff/1/pkg/analyzer/lib/src/summary/link.dart File pkg/analyzer/lib/src/summary/link.dart (right): https://codereview.chromium.org/2581803002/diff/1/pkg/analyzer/lib/src/summary/link.dart#newcode4710 pkg/analyzer/lib/src/summary/link.dart:4710: _futureOrType ??= _buildInterfaceType(_linker.asyncLibrary, 'Future'); Good catch. Done.
4 years ago (2016-12-15 20:54:39 UTC) #4
Brian Wilkerson
4 years ago (2016-12-15 20:56:00 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
cfcfe7a5cf0286fc3db24213739b1fff56255e99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698