Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: third_party/openh264/BUILD.gn

Issue 2581733002: Fix tautological comparison and add clang flag (Closed)
Patch Set: Remove clang warnings only when using clang Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « storage/browser/quota/quota_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/openh264/BUILD.gn
diff --git a/third_party/openh264/BUILD.gn b/third_party/openh264/BUILD.gn
index b2de306292dd1c4f81c7e4827ecb8e6720a72a7a..ad6c8a6cebc0490dfc31c38b973da94ec26ea73e 100644
--- a/third_party/openh264/BUILD.gn
+++ b/third_party/openh264/BUILD.gn
@@ -262,6 +262,12 @@ source_set("encoder") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
configs += [ ":config" ]
+
+ # TODO: Remove after fixing always-true condition
+ # third_party/openh264/src/codec/encoder/core/src/encoder_ext.cpp:142.
+ if (is_clang) {
+ configs -= [ "//build/config/clang:extra_warnings" ]
+ }
deps = [
":common",
":processing",
« no previous file with comments | « storage/browser/quota/quota_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698