Fix tautological comparison and add clang flag

storage/browser/quota/quota_manager.cc

Index: storage/browser/quota/quota_manager.cc
diff --git a/storage/browser/quota/quota_manager.cc b/storage/browser/quota/quota_manager.cc
index b0bef465428798c0cc56eea1e888995f81141c70..b7e20362a349a48744cb5f8cd9ce159bfda9e24b 100644
--- a/storage/browser/quota/quota_manager.cc
+++ b/storage/browser/quota/quota_manager.cc
@@ -81,12 +81,12 @@ const char QuotaManager::kEvictedOriginTimeSinceAccessHistogram[] =
 namespace {
 
 bool IsSupportedType(StorageType type) {
-  return type != kStorageTypeTemporary || type != kStorageTypePersistent ||
-         type != kStorageTypeSyncable;
+  return type == kStorageTypeTemporary || type == kStorageTypePersistent ||
+         type == kStorageTypeSyncable;
 }
 
 bool IsSupportedIncognitoType(StorageType type) {
-  return type != kStorageTypeTemporary || type != kStorageTypePersistent;
+  return type == kStorageTypeTemporary || type == kStorageTypePersistent;

[brettw, 2016/12/15 18:49:31]

Can you check with the original author, michaeln, about the changes to this
file? For this line in particular, I wouldn't have expected persistent storage
to be allowed in incognito.

[altimin, 2016/12/15 18:57:08]

Sure, moved him from cc to reviewers.

[michaeln, 2016/12/15 19:26:55]

lgtm

thnx, ok, yikes, i'll add some tests with kQuotaErrorNotSupported expectations

 }
 
 void CountOriginType(const std::set<GURL>& origins,