Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Side by Side Diff: build/config/clang/BUILD.gn

Issue 2581733002: Fix tautological comparison and add clang flag (Closed)
Patch Set: Remove clang warnings only when using clang Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | storage/browser/quota/quota_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("clang.gni") 5 import("clang.gni")
6 import("//build/config/chromecast_build.gni") 6 import("//build/config/chromecast_build.gni")
7 7
8 config("find_bad_constructs") { 8 config("find_bad_constructs") {
9 if (clang_use_chrome_plugins) { 9 if (clang_use_chrome_plugins) {
10 cflags = [] 10 cflags = []
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 } 49 }
50 50
51 # Enables some extra Clang-specific warnings. Some third-party code won't 51 # Enables some extra Clang-specific warnings. Some third-party code won't
52 # compile with these so may want to remove this config. 52 # compile with these so may want to remove this config.
53 config("extra_warnings") { 53 config("extra_warnings") {
54 cflags = [ 54 cflags = [
55 "-Wheader-hygiene", 55 "-Wheader-hygiene",
56 56
57 # Warns when a const char[] is converted to bool. 57 # Warns when a const char[] is converted to bool.
58 "-Wstring-conversion", 58 "-Wstring-conversion",
59
60 "-Wtautological-overlap-compare",
59 ] 61 ]
60 } 62 }
OLDNEW
« no previous file with comments | « no previous file | storage/browser/quota/quota_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698