Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 258173003: Remove static initializer in device/bluetooth/bluetooth_gatt_descriptor.cc. (Closed)

Created:
6 years, 7 months ago by Philippe
Modified:
6 years, 7 months ago
Reviewers:
armansito
CC:
chromium-reviews
Visibility:
Public.

Description

Remove static initializer in device/bluetooth/bluetooth_gatt_descriptor.cc. BUG=149314, 363543 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267251

Patch Set 1 : #

Patch Set 2 : Update unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -22 lines) Patch
M device/bluetooth/bluetooth_gatt_chromeos_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_descriptor.h View 6 chunks +6 lines, -6 lines 0 comments Download
M device/bluetooth/bluetooth_gatt_descriptor.cc View 1 chunk +63 lines, -12 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Philippe
6 years, 7 months ago (2014-04-29 12:14:32 UTC) #1
armansito
On 2014/04/29 12:14:32, Philippe wrote: lgtm, though you might have to modify bluetooth_gatt_unittests.cc as well, ...
6 years, 7 months ago (2014-04-29 15:09:37 UTC) #2
Philippe
On 2014/04/29 15:09:37, armansito wrote: > On 2014/04/29 12:14:32, Philippe wrote: > > lgtm, though ...
6 years, 7 months ago (2014-04-29 15:24:43 UTC) #3
Philippe
The CQ bit was checked by pliard@chromium.org
6 years, 7 months ago (2014-04-29 15:24:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/258173003/80001
6 years, 7 months ago (2014-04-29 15:24:57 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 16:18:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 16:18:09 UTC) #7
Philippe
The CQ bit was checked by pliard@chromium.org
6 years, 7 months ago (2014-04-30 08:57:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/258173003/80001
6 years, 7 months ago (2014-04-30 08:58:34 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 09:01:34 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 09:01:34 UTC) #11
Philippe
The CQ bit was checked by pliard@chromium.org
6 years, 7 months ago (2014-04-30 10:36:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/258173003/80001
6 years, 7 months ago (2014-04-30 10:36:36 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 10:40:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 10:40:20 UTC) #15
Philippe
The CQ bit was checked by pliard@chromium.org
6 years, 7 months ago (2014-04-30 12:35:53 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/258173003/80001
6 years, 7 months ago (2014-04-30 12:36:00 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 13:25:36 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium
6 years, 7 months ago (2014-04-30 13:25:36 UTC) #19
Philippe
The CQ bit was checked by pliard@chromium.org
6 years, 7 months ago (2014-04-30 15:29:00 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pliard@chromium.org/258173003/80001
6 years, 7 months ago (2014-04-30 15:29:13 UTC) #21
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 17:21:47 UTC) #22
Message was sent while issue was closed. 
Change committed as 267251

Powered by Google App Engine
This is Rietveld 408576698