Issue 258173002: Fix name setting when applying SVN settings in patches

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 258173002: Fix name setting when applying SVN settings in patches (Closed)

Created:
6 years, 7 months ago by Ryan Tseng

Modified:
6 years, 7 months ago

Reviewers:
agable

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Fix name setting when applying SVN settings in patches "name" is passed in as a function argument, but its "redelcared" in another iterator. Yay dynamic scoping. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=268593

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	checkout.py	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/258173002/1

6 years, 7 months ago (2014-05-06 19:57:41 UTC) #4

Message was sent while issue was closed.

Change committed as 268593