Issue 2581723002: cleanup Analyzer CLI and DDC arg parsing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2581723002: cleanup Analyzer CLI and DDC arg parsing (Closed)

Created:
4 years ago by danrubel

Modified:
4 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

cleanup Analyzer CLI and DDC arg parsing This removes the need to split arguments on '=' before calling the extractDefinedVariables method. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/e321439470ec016e9532afe57b7f2891c0282d83

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -7 lines)			Patch
M	pkg/analyzer/lib/src/command_line/arguments.dart	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/src/command_line/arguments_test.dart	View	1 chunk	+6 lines, -3 lines	0 comments	Download
M	pkg/analyzer_cli/lib/src/options.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer_cli/test/options_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/dev_compiler/test/codegen_test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

danrubel

4 years ago (2016-12-15 17:16:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e321439470ec016e9532afe57b7f2891c0282d83 (presubmit successful).