Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Side by Side Diff: chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc

Issue 2581703002: Disable TabCaptureApiTest.MaxOffscreenTabs on Mac on ASAN due to flakiness. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/location.h" 6 #include "base/location.h"
7 #include "base/single_thread_task_runner.h" 7 #include "base/single_thread_task_runner.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "base/test/test_timeouts.h" 9 #include "base/test/test_timeouts.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 TabCaptureCaptureOffscreenTabFunction::DetermineInitialSize( 159 TabCaptureCaptureOffscreenTabFunction::DetermineInitialSize(
160 options)); 160 options));
161 } 161 }
162 162
163 // Tests API behaviors, including info queries, and constraints violations. 163 // Tests API behaviors, including info queries, and constraints violations.
164 IN_PROC_BROWSER_TEST_F(TabCaptureApiTest, ApiTests) { 164 IN_PROC_BROWSER_TEST_F(TabCaptureApiTest, ApiTests) {
165 AddExtensionToCommandLineWhitelist(); 165 AddExtensionToCommandLineWhitelist();
166 ASSERT_TRUE(RunExtensionSubtest("tab_capture", "api_tests.html")) << message_; 166 ASSERT_TRUE(RunExtensionSubtest("tab_capture", "api_tests.html")) << message_;
167 } 167 }
168 168
169 #if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER)
170 // Flaky on ASAN on Mac. See https://crbug.com/674497.
171 #define MAYBE_MaxOffscreenTabs DISABLED_MaxOffscreenTabs
172 #else
173 #define MAYBE_MaxOffscreenTabs MaxOffscreenTabs
174 #endif
169 // Tests that there is a maximum limitation to the number of simultaneous 175 // Tests that there is a maximum limitation to the number of simultaneous
170 // off-screen tabs. 176 // off-screen tabs.
171 IN_PROC_BROWSER_TEST_F(TabCaptureApiTest, MaxOffscreenTabs) { 177 IN_PROC_BROWSER_TEST_F(TabCaptureApiTest, MAYBE_MaxOffscreenTabs) {
172 AddExtensionToCommandLineWhitelist(); 178 AddExtensionToCommandLineWhitelist();
173 ASSERT_TRUE(RunExtensionSubtest("tab_capture", "max_offscreen_tabs.html")) 179 ASSERT_TRUE(RunExtensionSubtest("tab_capture", "max_offscreen_tabs.html"))
174 << message_; 180 << message_;
175 } 181 }
176 182
177 // Tests that tab capture video frames can be received in a VIDEO element. 183 // Tests that tab capture video frames can be received in a VIDEO element.
178 IN_PROC_BROWSER_TEST_F(TabCaptureApiPixelTest, EndToEndWithoutRemoting) { 184 IN_PROC_BROWSER_TEST_F(TabCaptureApiPixelTest, EndToEndWithoutRemoting) {
179 if (IsTooIntensiveForThisPlatform()) { 185 if (IsTooIntensiveForThisPlatform()) {
180 LOG(WARNING) << "Skipping this CPU-intensive test on this platform/build."; 186 LOG(WARNING) << "Skipping this CPU-intensive test on this platform/build.";
181 return; 187 return;
(...skipping 281 matching lines...) Expand 10 before | Expand all | Expand 10 after
463 EXPECT_EQ(TabAlertState::TAB_CAPTURING, observer.last_alert_state()); 469 EXPECT_EQ(TabAlertState::TAB_CAPTURING, observer.last_alert_state());
464 return; 470 return;
465 } 471 }
466 content::RunMessageLoop(); 472 content::RunMessageLoop();
467 } 473 }
468 } 474 }
469 475
470 } // namespace 476 } // namespace
471 477
472 } // namespace extensions 478 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698