Issue 2581693002: Allocate fewer objects in dartk frontend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2581693002: Allocate fewer objects in dartk frontend. (Closed)

Created:
4 years ago by asgerf

Modified:
4 years ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Allocate fewer objects in dartk frontend. TypeAnnotationBuilder and InterfaceType were being allocated a bit aggressively. It makes no measurable difference on runtime, but it rules out some of these objects as potential culprits. R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/456f9b50b654093778e6e5fe98a52501bb8406e2

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -23 lines)			Patch
	M	pkg/kernel/lib/analyzer/ast_from_analyzer.dart	View		17 chunks	+45 lines, -23 lines	0 comments	Download

Total messages: 5 (2 generated)

asgerf

4 years ago (2016-12-15 12:44:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
456f9b50b654093778e6e5fe98a52501bb8406e2 (presubmit successful).