src/full-codegen/ia32/full-codegen-ia32.cc - Issue 2581683003: Introduce {ConstantElementsPair} struct for type safety.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2581683003: Introduce {ConstantElementsPair} struct for type safety. (Closed)

Patch Set: Re-cemment bytecode tests. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/ia32/full-codegen-ia32.cc

diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc

index cad7c570eba1a1b542bfda4254bf2e057bc9fadb..9ffa65211dfc83fa5358df0fad579a44f314e605 100644

--- a/src/full-codegen/ia32/full-codegen-ia32.cc

+++ b/src/full-codegen/ia32/full-codegen-ia32.cc

@@ -1257,7 +1257,7 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {

Comment cmnt(masm_, "[ ArrayLiteral");

- Handle<FixedArray> constant_elements = expr->constant_elements();

+ Handle<ConstantElementsPair> constant_elements = expr->constant_elements();

bool has_constant_fast_elements =

IsFastObjectElementsKind(expr->constant_elements_kind());