src/crankshaft/hydrogen.cc - Issue 2581683003: Introduce {ConstantElementsPair} struct for type safety.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/hydrogen.cc

Issue 2581683003: Introduce {ConstantElementsPair} struct for type safety. (Closed)

Patch Set: Re-cemment bytecode tests. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/hydrogen.cc

diff --git a/src/crankshaft/hydrogen.cc b/src/crankshaft/hydrogen.cc

index e041c5904b1a08a7ef3f6c6e02ac917e62e88d6d..325b398b2ac3e6f202104ef130e5854d07ba18be 100644

--- a/src/crankshaft/hydrogen.cc

+++ b/src/crankshaft/hydrogen.cc

@@ -5641,7 +5641,7 @@ void HOptimizedGraphBuilder::VisitArrayLiteral(ArrayLiteral* expr) {

site_context.ExitScope(site, boilerplate_object);

} else {

NoObservableSideEffectsScope no_effects(this);

- Handle<FixedArray> constants = expr->constant_elements();

+ Handle<ConstantElementsPair> constants = expr->constant_elements();

int literal_index = expr->literal_index();

int flags = expr->ComputeFlags(true);