Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 2581683003: Introduce {ConstantElementsPair} struct for type safety. (Closed)
Patch Set: Rebased. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1267 matching lines...) Expand 10 before | Expand all | Expand 10 after
1278 context()->PlugTOS(); 1278 context()->PlugTOS();
1279 } else { 1279 } else {
1280 context()->Plug(rax); 1280 context()->Plug(rax);
1281 } 1281 }
1282 } 1282 }
1283 1283
1284 1284
1285 void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { 1285 void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
1286 Comment cmnt(masm_, "[ ArrayLiteral"); 1286 Comment cmnt(masm_, "[ ArrayLiteral");
1287 1287
1288 Handle<FixedArray> constant_elements = expr->constant_elements(); 1288 Handle<ConstantElementsPair> constant_elements = expr->constant_elements();
1289 bool has_constant_fast_elements = 1289 bool has_constant_fast_elements =
1290 IsFastObjectElementsKind(expr->constant_elements_kind()); 1290 IsFastObjectElementsKind(expr->constant_elements_kind());
1291 1291
1292 AllocationSiteMode allocation_site_mode = TRACK_ALLOCATION_SITE; 1292 AllocationSiteMode allocation_site_mode = TRACK_ALLOCATION_SITE;
1293 if (has_constant_fast_elements && !FLAG_allocation_site_pretenuring) { 1293 if (has_constant_fast_elements && !FLAG_allocation_site_pretenuring) {
1294 // If the only customer of allocation sites is transitioning, then 1294 // If the only customer of allocation sites is transitioning, then
1295 // we can turn it off if we don't have anywhere else to transition to. 1295 // we can turn it off if we don't have anywhere else to transition to.
1296 allocation_site_mode = DONT_TRACK_ALLOCATION_SITE; 1296 allocation_site_mode = DONT_TRACK_ALLOCATION_SITE;
1297 } 1297 }
1298 1298
(...skipping 1471 matching lines...) Expand 10 before | Expand all | Expand 10 after
2770 DCHECK_EQ( 2770 DCHECK_EQ(
2771 isolate->builtins()->OnStackReplacement()->entry(), 2771 isolate->builtins()->OnStackReplacement()->entry(),
2772 Assembler::target_address_at(call_target_address, unoptimized_code)); 2772 Assembler::target_address_at(call_target_address, unoptimized_code));
2773 return ON_STACK_REPLACEMENT; 2773 return ON_STACK_REPLACEMENT;
2774 } 2774 }
2775 2775
2776 } // namespace internal 2776 } // namespace internal
2777 } // namespace v8 2777 } // namespace v8
2778 2778
2779 #endif // V8_TARGET_ARCH_X64 2779 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/full-codegen/s390/full-codegen-s390.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698