Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2581683003: Introduce {ConstantElementsPair} struct for type safety. (Closed)
Patch Set: Rebased. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/full-codegen/full-codegen.h" 7 #include "src/full-codegen/full-codegen.h"
8 #include "src/ast/compile-time-value.h" 8 #include "src/ast/compile-time-value.h"
9 #include "src/ast/scopes.h" 9 #include "src/ast/scopes.h"
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 1239 matching lines...) Expand 10 before | Expand all | Expand 10 after
1250 context()->PlugTOS(); 1250 context()->PlugTOS();
1251 } else { 1251 } else {
1252 context()->Plug(eax); 1252 context()->Plug(eax);
1253 } 1253 }
1254 } 1254 }
1255 1255
1256 1256
1257 void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { 1257 void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) {
1258 Comment cmnt(masm_, "[ ArrayLiteral"); 1258 Comment cmnt(masm_, "[ ArrayLiteral");
1259 1259
1260 Handle<FixedArray> constant_elements = expr->constant_elements(); 1260 Handle<ConstantElementsPair> constant_elements = expr->constant_elements();
1261 bool has_constant_fast_elements = 1261 bool has_constant_fast_elements =
1262 IsFastObjectElementsKind(expr->constant_elements_kind()); 1262 IsFastObjectElementsKind(expr->constant_elements_kind());
1263 1263
1264 AllocationSiteMode allocation_site_mode = TRACK_ALLOCATION_SITE; 1264 AllocationSiteMode allocation_site_mode = TRACK_ALLOCATION_SITE;
1265 if (has_constant_fast_elements && !FLAG_allocation_site_pretenuring) { 1265 if (has_constant_fast_elements && !FLAG_allocation_site_pretenuring) {
1266 // If the only customer of allocation sites is transitioning, then 1266 // If the only customer of allocation sites is transitioning, then
1267 // we can turn it off if we don't have anywhere else to transition to. 1267 // we can turn it off if we don't have anywhere else to transition to.
1268 allocation_site_mode = DONT_TRACK_ALLOCATION_SITE; 1268 allocation_site_mode = DONT_TRACK_ALLOCATION_SITE;
1269 } 1269 }
1270 1270
(...skipping 1517 matching lines...) Expand 10 before | Expand all | Expand 10 after
2788 isolate->builtins()->OnStackReplacement()->entry(), 2788 isolate->builtins()->OnStackReplacement()->entry(),
2789 Assembler::target_address_at(call_target_address, unoptimized_code)); 2789 Assembler::target_address_at(call_target_address, unoptimized_code));
2790 return ON_STACK_REPLACEMENT; 2790 return ON_STACK_REPLACEMENT;
2791 } 2791 }
2792 2792
2793 2793
2794 } // namespace internal 2794 } // namespace internal
2795 } // namespace v8 2795 } // namespace v8
2796 2796
2797 #endif // V8_TARGET_ARCH_IA32 2797 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698