third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp - Issue 2581633002: [FirstMeaningfulPaint] Do not stop observing layouts before FirstContentfulPaint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

Issue 2581633002: [FirstMeaningfulPaint] Do not stop observing layouts before FirstContentfulPaint (Closed)

Patch Set: fix&add test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

diff --git a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

index f593ead9c241b688deb40dcb5b7eae50fc80311e..cc0bd7788dcd4d3214d42414c1161a084e41a1cb 100644

--- a/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

+++ b/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp

@@ -115,7 +115,8 @@ void FirstMeaningfulPaintDetector::checkNetworkStable() {

void FirstMeaningfulPaintDetector::networkStableTimerFired(TimerBase*) {

if (m_state == Reported || !document() ||

- document()->fetcher()->hasPendingRequest())

+ document()->fetcher()->hasPendingRequest() ||

+ !m_paintTiming->firstContentfulPaint())

return;

if (m_provisionalFirstMeaningfulPaint)

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetectorTest.cpp » ('j') | no next file with comments »