MSE: Fix logic bugs with high precision duration

third_party/WebKit/Source/core/html/shadow/MediaControlsOrientationLockDelegateTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/html/shadow/MediaControlsOrientationLockDelegate.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/DocumentUserGestureToken.h"
 #include "core/dom/Fullscreen.h"
 #include "core/frame/ScreenOrientationController.h"
@@ skipping 317 matching lines @@
 
   simulateEnterFullscreen();
   // State set to MaybeLockedFullscreen.
   simulateExitFullscreen();
 
   EXPECT_FALSE(delegateWillUnlockFullscreen());
   checkStatePendingFullscreen();
 }
 
 TEST_F(MediaControlsOrientationLockDelegateTest,
        ReceivedMetadataAfterExitingFullscreen) {

[chcunningham, 2017/01/04 00:11:54]

Mounir, some questions for you here. 

This test claims to exit full screen, but I don't see that it does. Should I add
a call to simulateExitFullscreen()?

   EXPECT_CALL(screenOrientationController(), lock(_)).Times(1);
 
   simulateEnterFullscreen();
   // State set to PendingMetadata.

[chcunningham, 2017/01/04 00:11:54]

This comment is dangling.

[mlamouri (slow - plz ping), 2017/01/10 14:29:30]

It's not though I agree it's unclear: the internal state is now
`PendingMetadata` after the `simulateEnterFullscreen()`  call. I don't test it
because it was tested somewhere else.

 
+  // Set up the WebMediaPlayer instance.
+  video().setSrc("http://example.com");
+  testing::runPendingTasks();
+
   simulateVideoNetworkState(HTMLMediaElement::kNetworkIdle);
   simulateVideoReadyState(HTMLMediaElement::kHaveMetadata);
   testing::runPendingTasks();
 
   checkStateMaybeLockedFullscreen();
 }
 
 TEST_F(MediaControlsOrientationLockDelegateTest, ReceivedMetadataLater) {
   EXPECT_CALL(screenOrientationController(), lock(_)).Times(0);
   EXPECT_CALL(screenOrientationController(), mockUnlock()).Times(0);
 
   simulateEnterFullscreen();
   // State set to PendingMetadata.

[chcunningham, 2017/01/04 00:11:54]

I don't follow this comment.

[mlamouri (slow - plz ping), 2017/01/10 14:29:30]

As above.

   simulateExitFullscreen();
 
+  // Set up the WebMediaPlayer instance.
+  video().setSrc("http://example.com");
+  testing::runPendingTasks();
+
   simulateVideoNetworkState(HTMLMediaElement::kNetworkIdle);
   simulateVideoReadyState(HTMLMediaElement::kHaveMetadata);
   testing::runPendingTasks();
 
   checkStatePendingFullscreen();
 }
 
 TEST_F(MediaControlsOrientationLockDelegateTest, ComputeOrientationLock) {
   // Set up the WebMediaPlayer instance.
   video().setSrc("http://example.com");
@@ skipping 43 matching lines @@
   EXPECT_EQ(WebScreenOrientationLockLandscape, computeOrientationLock());
 
   screenInfo.orientationType = WebScreenOrientationLandscapeSecondary;
   EXPECT_CALL(chromeClient(), screenInfo())
       .Times(1)
       .WillOnce(Return(screenInfo));
   EXPECT_EQ(WebScreenOrientationLockLandscape, computeOrientationLock());
 }
 
 }  // namespace blink