PageInfo bubble: Use the non-client view's window title and close button.

ui/views/bubble/bubble_dialog_delegate.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_BUBBLE_BUBBLE_DIALOG_DELEGATE_H_
 #define UI_VIEWS_BUBBLE_BUBBLE_DIALOG_DELEGATE_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/macros.h"
 #include "ui/views/bubble/bubble_border.h"
@@ skipping 61 matching lines @@
   void set_shadow(BubbleBorder::Shadow shadow) { shadow_ = shadow; }
 
   SkColor color() const { return color_; }
   void set_color(SkColor color) {
     color_ = color;
     color_explicitly_set_ = true;
   }
 
   const gfx::Insets& margins() const { return margins_; }
   void set_margins(const gfx::Insets& margins) { margins_ = margins; }
+  const gfx::Insets& title_margins() const { return title_margins_; }
+  void set_title_margins(const gfx::Insets& title_margins) {

[msw, 2017/01/05 01:00:00]

Bummer, it seems like we need this mostly so the website settings bubble can
left-align its title with the rest of its content. It'd be nice to avoid custom
title margins and instead use the standard title/panel margins for the content
(ie. make the content's left-margin match the title's left-margin, instead of
the inverse). It's a difference of 3px on top and left, afaict:
kPanelHorizMargin==13 vs kSectionPaddingHorizontal==16, and kPanelVertMargin==13
vs kHeaderPaddingTop==16. wdyt?

[tapted, 2017/01/05 02:20:42]

Done. Added a screenshot at http://crbug.com/674269#c7

+    title_margins_ = title_margins;
+  }
 
   const gfx::Insets& anchor_view_insets() const { return anchor_view_insets_; }
   void set_anchor_view_insets(const gfx::Insets& i) { anchor_view_insets_ = i; }
 
   gfx::NativeView parent_window() const { return parent_window_; }
   void set_parent_window(gfx::NativeView window) { parent_window_ = window; }
 
   bool accept_events() const { return accept_events_; }
   void set_accept_events(bool accept_events) { accept_events_ = accept_events; }
 
@@ skipping 91 matching lines @@
 
   // Bubble border shadow to use.
   BubbleBorder::Shadow shadow_;
 
   // The background color of the bubble; and flag for when it's explicitly set.
   SkColor color_;
   bool color_explicitly_set_;
 
   // The margins between the content and the inside of the border.
   gfx::Insets margins_;
+  gfx::Insets title_margins_;
 
   // Insets applied to the |anchor_view_| bounds.
   gfx::Insets anchor_view_insets_;
 
   // Specifies whether the bubble (or its border) handles mouse events, etc.
   bool accept_events_;
   bool border_accepts_events_;
 
   // If true (defaults to true), the arrow may be mirrored and moved to fit the
   // bubble on screen better. It would be a no-op if the bubble has no arrow.
   bool adjust_if_offscreen_;
 
   // Parent native window of the bubble.
   gfx::NativeView parent_window_;
 
   DISALLOW_COPY_AND_ASSIGN(BubbleDialogDelegateView);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_BUBBLE_BUBBLE_DELEGATE2_H_