Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(926)

Side by Side Diff: content/browser/accessibility/browser_accessibility_state_impl.cc

Issue 2581483002: Add support for faster, more limited accessibility modes. (Closed)
Patch Set: Android compile fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/accessibility/browser_accessibility_state_impl.h" 5 #include "content/browser/accessibility/browser_accessibility_state_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
11 #include "build/build_config.h" 11 #include "build/build_config.h"
12 #include "content/browser/renderer_host/render_widget_host_impl.h" 12 #include "content/browser/renderer_host/render_widget_host_impl.h"
13 #include "content/browser/web_contents/web_contents_impl.h" 13 #include "content/browser/web_contents/web_contents_impl.h"
14 #include "content/public/browser/browser_thread.h" 14 #include "content/public/browser/browser_thread.h"
15 #include "content/public/common/content_switches.h" 15 #include "content/public/common/content_switches.h"
16 #include "ui/gfx/color_utils.h" 16 #include "ui/gfx/color_utils.h"
17 17
18 namespace content { 18 namespace content {
19 19
20 // IMPORTANT!
21 // These values are written to logs. Do not renumber or delete
22 // existing items; add new entries to the end of the list.
23 enum {
24 UMA_AX_MODE_FLAG_NATIVE_APIS = 0,
25 UMA_AX_MODE_FLAG_WEB_CONTENTS = 1,
26 UMA_AX_MODE_FLAG_INLINE_TEXT_BOXES = 2,
27 UMA_AX_MODE_FLAG_SCREEN_READER = 3,
28 UMA_AX_MODE_FLAG_HTML = 4,
29
30 // This must always be the last enum. It's okay for its value to
31 // increase, but none of the other enum values may change.
32 UMA_AX_MODE_FLAG_MAX
33 };
34
20 // Update the accessibility histogram 45 seconds after initialization. 35 // Update the accessibility histogram 45 seconds after initialization.
21 static const int kAccessibilityHistogramDelaySecs = 45; 36 static const int kAccessibilityHistogramDelaySecs = 45;
22 37
23 // static 38 // static
24 BrowserAccessibilityState* BrowserAccessibilityState::GetInstance() { 39 BrowserAccessibilityState* BrowserAccessibilityState::GetInstance() {
25 return BrowserAccessibilityStateImpl::GetInstance(); 40 return BrowserAccessibilityStateImpl::GetInstance();
26 } 41 }
27 42
28 // static 43 // static
29 BrowserAccessibilityStateImpl* BrowserAccessibilityStateImpl::GetInstance() { 44 BrowserAccessibilityStateImpl* BrowserAccessibilityStateImpl::GetInstance() {
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 } 141 }
127 #endif 142 #endif
128 143
129 void BrowserAccessibilityStateImpl::AddAccessibilityModeFlags( 144 void BrowserAccessibilityStateImpl::AddAccessibilityModeFlags(
130 AccessibilityMode mode) { 145 AccessibilityMode mode) {
131 if (base::CommandLine::ForCurrentProcess()->HasSwitch( 146 if (base::CommandLine::ForCurrentProcess()->HasSwitch(
132 switches::kDisableRendererAccessibility)) { 147 switches::kDisableRendererAccessibility)) {
133 return; 148 return;
134 } 149 }
135 150
151 AccessibilityMode previous_mode = accessibility_mode_;
136 accessibility_mode_ |= mode; 152 accessibility_mode_ |= mode;
153 if (accessibility_mode_ == previous_mode)
154 return;
155
156 AccessibilityMode new_mode_flags = accessibility_mode_ & (~previous_mode);
157 if (new_mode_flags & ACCESSIBILITY_MODE_FLAG_NATIVE_APIS) {
158 UMA_HISTOGRAM_ENUMERATION("Accessibility.ModeFlag",
159 UMA_AX_MODE_FLAG_NATIVE_APIS,
160 UMA_AX_MODE_FLAG_MAX);
Ilya Sherman 2016/12/17 00:57:12 nit: Please factor out a function for recording to
dmazzoni 2016/12/19 22:51:50 Done.
161 }
162 if (new_mode_flags & ACCESSIBILITY_MODE_FLAG_WEB_CONTENTS) {
163 UMA_HISTOGRAM_ENUMERATION("Accessibility.ModeFlag",
164 UMA_AX_MODE_FLAG_WEB_CONTENTS,
165 UMA_AX_MODE_FLAG_MAX);
166 }
167 if (new_mode_flags & ACCESSIBILITY_MODE_FLAG_INLINE_TEXT_BOXES) {
168 UMA_HISTOGRAM_ENUMERATION("Accessibility.ModeFlag",
169 UMA_AX_MODE_FLAG_INLINE_TEXT_BOXES,
170 UMA_AX_MODE_FLAG_MAX);
171 }
172 if (new_mode_flags & ACCESSIBILITY_MODE_FLAG_SCREEN_READER) {
173 UMA_HISTOGRAM_ENUMERATION("Accessibility.ModeFlag",
174 UMA_AX_MODE_FLAG_SCREEN_READER,
175 UMA_AX_MODE_FLAG_MAX);
176 }
177 if (new_mode_flags & ACCESSIBILITY_MODE_FLAG_HTML) {
178 UMA_HISTOGRAM_ENUMERATION("Accessibility.ModeFlag",
179 UMA_AX_MODE_FLAG_HTML,
180 UMA_AX_MODE_FLAG_MAX);
181 }
182
137 std::vector<WebContentsImpl*> web_contents_vector = 183 std::vector<WebContentsImpl*> web_contents_vector =
138 WebContentsImpl::GetAllWebContents(); 184 WebContentsImpl::GetAllWebContents();
139 for (size_t i = 0; i < web_contents_vector.size(); ++i) 185 for (size_t i = 0; i < web_contents_vector.size(); ++i)
140 web_contents_vector[i]->AddAccessibilityMode(accessibility_mode_); 186 web_contents_vector[i]->AddAccessibilityMode(accessibility_mode_);
141 } 187 }
142 188
143 void BrowserAccessibilityStateImpl::RemoveAccessibilityModeFlags( 189 void BrowserAccessibilityStateImpl::RemoveAccessibilityModeFlags(
144 AccessibilityMode mode) { 190 AccessibilityMode mode) {
145 if (base::CommandLine::ForCurrentProcess()->HasSwitch( 191 if (base::CommandLine::ForCurrentProcess()->HasSwitch(
146 switches::kForceRendererAccessibility) && 192 switches::kForceRendererAccessibility) &&
147 mode == ACCESSIBILITY_MODE_COMPLETE) { 193 mode == ACCESSIBILITY_MODE_COMPLETE) {
148 return; 194 return;
149 } 195 }
150 196
151 accessibility_mode_ = accessibility_mode_ ^ (mode & accessibility_mode_); 197 accessibility_mode_ = accessibility_mode_ ^ (mode & accessibility_mode_);
152 std::vector<WebContentsImpl*> web_contents_vector = 198 std::vector<WebContentsImpl*> web_contents_vector =
153 WebContentsImpl::GetAllWebContents(); 199 WebContentsImpl::GetAllWebContents();
154 for (size_t i = 0; i < web_contents_vector.size(); ++i) 200 for (size_t i = 0; i < web_contents_vector.size(); ++i)
155 web_contents_vector[i]->SetAccessibilityMode(accessibility_mode()); 201 web_contents_vector[i]->SetAccessibilityMode(accessibility_mode());
156 } 202 }
157 203
158 } // namespace content 204 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698