Source/core/dom/Element.cpp - Issue 258143002: Oilpan: move DOM string collection objects to the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.cpp

Issue 258143002: Oilpan: move DOM string collection objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase + final adjustments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.cpp

diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp

index 17abe3fc80b7b7c95500e7651172b4da4b456598..4ca847c02e38ed951f6abf59ccd9f4336b454624 100644

--- a/Source/core/dom/Element.cpp

+++ b/Source/core/dom/Element.cpp

@@ -3296,10 +3296,9 @@ bool Element::supportsStyleSharing() const

void Element::trace(Visitor* visitor)

{

- // FIXME: Oilpan: Perform this tracing directly on the element

- // rare data once that is in the heap.

if (hasRareData())

- elementRareData()->trace(visitor);

+ visitor->trace(elementRareData());

ContainerNode::trace(visitor);

}

« no previous file with comments | « Source/core/dom/DatasetDOMStringMap.cpp ('k') | Source/core/dom/ElementRareData.h » ('j') | no next file with comments »