Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: Source/core/dom/DOMStringMap.h

Issue 258143002: Oilpan: move DOM string collection objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase + final adjustments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/DOMStringList.idl ('k') | Source/core/dom/DOMStringMap.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/DOMStringMap.h
diff --git a/Source/core/dom/DOMStringMap.h b/Source/core/dom/DOMStringMap.h
index fb4d17bc72d67e05e552096d2f58cd18be92ec2a..83095794734d6d4bad7e8974a35c44d116f4c2bf 100644
--- a/Source/core/dom/DOMStringMap.h
+++ b/Source/core/dom/DOMStringMap.h
@@ -29,6 +29,7 @@
#include "bindings/v8/ExceptionState.h"
#include "bindings/v8/ScriptWrappable.h"
#include "bindings/v8/V8Binding.h"
+#include "platform/heap/Handle.h"
#include "wtf/Noncopyable.h"
#include "wtf/Vector.h"
#include "wtf/text/WTFString.h"
@@ -37,13 +38,16 @@ namespace WebCore {
class Element;
-class DOMStringMap : public ScriptWrappable {
- WTF_MAKE_NONCOPYABLE(DOMStringMap); WTF_MAKE_FAST_ALLOCATED;
+class DOMStringMap : public NoBaseWillBeGarbageCollectedFinalized<DOMStringMap>, public ScriptWrappable {
+ WTF_MAKE_NONCOPYABLE(DOMStringMap);
+ WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED;
public:
virtual ~DOMStringMap();
+#if !ENABLE(OILPAN)
virtual void ref() = 0;
virtual void deref() = 0;
+#endif
virtual void getNames(Vector<String>&) = 0;
virtual String item(const String& name) = 0;
@@ -81,6 +85,8 @@ public:
virtual Element* element() = 0;
+ virtual void trace(Visitor*) { }
+
protected:
DOMStringMap()
{
« no previous file with comments | « Source/core/dom/DOMStringList.idl ('k') | Source/core/dom/DOMStringMap.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698