Source/core/html/HTMLFormControlElement.cpp - Issue 258143002: Oilpan: move DOM string collection objects to the Oilpan heap.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 258143002: Oilpan: move DOM string collection objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased to meet NodeRareData CL Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2001 Dirk Mueller (mueller@kde.org)	4 * (C) 2001 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.

6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)	6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)

7 *	7 *

8 * This library is free software; you can redistribute it and/or	8 * This library is free software; you can redistribute it and/or

9 * modify it under the terms of the GNU Library General Public	9 * modify it under the terms of the GNU Library General Public

10 * License as published by the Free Software Foundation; either	10 * License as published by the Free Software Foundation; either

(...skipping 486 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
497 }	497 }

498	498

499 void HTMLFormControlElement::setFocus(bool flag)	499 void HTMLFormControlElement::setFocus(bool flag)

500 {	500 {

501 LabelableElement::setFocus(flag);	501 LabelableElement::setFocus(flag);

502	502

503 if (!flag && wasChangedSinceLastFormControlChangeEvent())	503 if (!flag && wasChangedSinceLastFormControlChangeEvent())

504 dispatchFormControlChangeEvent();	504 dispatchFormControlChangeEvent();

505 }	505 }

506	506

	507 void HTMLFormControlElement::trace(Visitor* visitor)
	haraken 2014/05/08 11:59:59 tkent-san already implemented this when moving For tkent-san already implemented this when moving FormAssociatedElement to the heap. I think you just need to rebase. sof 2014/05/08 14:05:22 Yes, removed this trace() when rebasing just now. Show quoted text On 2014/05/08 11:59:59, haraken wrote: > > tkent-san already implemented this when moving FormAssociatedElement to the > heap. I think you just need to rebase. Yes, removed this trace() when rebasing just now.
	508 {

	509 LabelableElement::trace(visitor);

	510 }

	511

507 } // namespace Webcore	512 } // namespace Webcore

OLD	NEW