Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: Source/core/dom/DatasetDOMStringMap.cpp

Issue 258143002: Oilpan: move DOM string collection objects to the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 if (isASCIIUpper(character)) { 133 if (isASCIIUpper(character)) {
134 builder.append('-'); 134 builder.append('-');
135 builder.append(toASCIILower(character)); 135 builder.append(toASCIILower(character));
136 } else 136 } else
137 builder.append(character); 137 builder.append(character);
138 } 138 }
139 139
140 return builder.toAtomicString(); 140 return builder.toAtomicString();
141 } 141 }
142 142
143 #if !ENABLE(OILPAN)
143 void DatasetDOMStringMap::ref() 144 void DatasetDOMStringMap::ref()
144 { 145 {
145 m_element->ref(); 146 m_element->ref();
146 } 147 }
147 148
148 void DatasetDOMStringMap::deref() 149 void DatasetDOMStringMap::deref()
149 { 150 {
150 m_element->deref(); 151 m_element->deref();
151 } 152 }
153 #endif
152 154
153 void DatasetDOMStringMap::getNames(Vector<String>& names) 155 void DatasetDOMStringMap::getNames(Vector<String>& names)
154 { 156 {
155 if (!m_element->hasAttributes()) 157 if (!m_element->hasAttributes())
156 return; 158 return;
157 159
158 unsigned length = m_element->attributeCount(); 160 unsigned length = m_element->attributeCount();
159 for (unsigned i = 0; i < length; i++) { 161 for (unsigned i = 0; i < length; i++) {
160 const Attribute& attribute = m_element->attributeItem(i); 162 const Attribute& attribute = m_element->attributeItem(i);
161 if (isValidAttributeName(attribute.localName())) 163 if (isValidAttributeName(attribute.localName()))
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
208 if (isValidPropertyName(name)) { 210 if (isValidPropertyName(name)) {
209 AtomicString attributeName = convertPropertyNameToAttributeName(name); 211 AtomicString attributeName = convertPropertyNameToAttributeName(name);
210 if (m_element->hasAttribute(attributeName)) { 212 if (m_element->hasAttribute(attributeName)) {
211 m_element->removeAttribute(attributeName); 213 m_element->removeAttribute(attributeName);
212 return true; 214 return true;
213 } 215 }
214 } 216 }
215 return false; 217 return false;
216 } 218 }
217 219
220 void DatasetDOMStringMap::trace(Visitor* visitor)
221 {
222 visitor->trace(m_element);
Mads Ager (chromium) 2014/04/29 09:05:14 Yeah, since you are tracing m_element, please put
223 DOMStringMap::trace(visitor);
224 }
225
218 } // namespace WebCore 226 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698