Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 25814003: Remove disable-gpu-vsync about:flags entry (Closed)

Created:
7 years, 2 months ago by jamesr
Modified:
7 years, 2 months ago
Reviewers:
brianderson, jbauman
CC:
chromium-reviews
Visibility:
Public.

Description

Remove disable-gpu-vsync about:flags entry This entry completely breaks Chrome and has for a while. BUG=303293 R=jbauman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
Not tested yet, but this should work.
7 years, 2 months ago (2013-10-02 23:54:27 UTC) #1
jbauman
lgtm
7 years, 2 months ago (2013-10-02 23:55:47 UTC) #2
jamesr
Committed patchset #1 manually as r226626.
7 years, 2 months ago (2013-10-03 00:17:06 UTC) #3
brianderson
Thanks for removing this James. I guess we'll keep the entries in chrome/app/generated_resources.grd so we ...
7 years, 2 months ago (2013-10-03 00:27:05 UTC) #4
jamesr
On 2013/10/03 00:27:05, Brian Anderson wrote: > Thanks for removing this James. I guess we'll ...
7 years, 2 months ago (2013-10-03 00:29:14 UTC) #5
Jamie Madill
7 years, 2 months ago (2013-10-03 15:20:08 UTC) #6
Message was sent while issue was closed.
On 2013/10/03 00:29:14, jamesr wrote:
> If we decide we don't want to support this at all we can remove the grd
entries,
> but that seems less likely to me.

+1 for keeping the disable vsync flag... the ANGLE team relies on vsync-disable
for testing performance regressions in WebGL demos.

Powered by Google App Engine
This is Rietveld 408576698