Issue 2581363002: Fuchsia: resolve executable name, fetch environment vars

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2581363002: Fuchsia: resolve executable name, fetch environment vars (Closed)

Created:
4 years ago by zra

Modified:
4 years ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fuchsia: resolve executable name, fetch environment vars R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/1f289fc12bf0b18e14d68b9f07f2e43b5885ed15

Patch Set 2 : Cleanup #

Total comments: 1

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -6 lines)			Patch
M	runtime/bin/file_fuchsia.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/bin/platform_fuchsia.cc	View		2 chunks	+49 lines, -4 lines	1 comment	Download
M	runtime/tests/vm/dart/hello_fuchsia_test.dart	View		3 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

LGTM https://codereview.chromium.org/2581363002/diff/20001/runtime/bin/platform_fuchsia.cc File runtime/bin/platform_fuchsia.cc (right): https://codereview.chromium.org/2581363002/diff/20001/runtime/bin/platform_fuchsia.cc#newcode106 runtime/bin/platform_fuchsia.cc:106: // Platform.resovledExecutable. resolved

4 years ago (2016-12-16 23:05:01 UTC) #3

zra

4 years ago (2016-12-17 05:23:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1f289fc12bf0b18e14d68b9f07f2e43b5885ed15 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 2581363002: Fuchsia: resolve executable name, fetch environment vars (Closed)

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Messages