Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 258133002: Ensures that stubs added to each object pool on x64 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_x64.cc
===================================================================
--- runtime/vm/assembler_x64.cc (revision 35483)
+++ runtime/vm/assembler_x64.cc (working copy)
@@ -45,17 +45,19 @@
patchable_pool_entries_.Add(kNotPatchable);
object_pool_index_table_.Insert(ObjIndexPair(Bool::False().raw(), 2));
+ const Smi& vacant = Smi::Handle(Smi::New(0xfa));
Ivan Posva 2014/04/29 05:31:04 ditto
zra 2014/04/29 14:47:49 Done.
+
if (StubCode::UpdateStoreBuffer_entry() != NULL) {
FindExternalLabel(&StubCode::UpdateStoreBufferLabel(), kNotPatchable);
} else {
- object_pool_.Add(Object::null_object(), Heap::kOld);
+ object_pool_.Add(vacant, Heap::kOld);
patchable_pool_entries_.Add(kNotPatchable);
}
if (StubCode::CallToRuntime_entry() != NULL) {
FindExternalLabel(&StubCode::CallToRuntimeLabel(), kNotPatchable);
} else {
- object_pool_.Add(Object::null_object(), Heap::kOld);
+ object_pool_.Add(vacant, Heap::kOld);
patchable_pool_entries_.Add(kNotPatchable);
}
@@ -65,7 +67,7 @@
FindExternalLabel(&StubCode::BreakpointRuntimeLabel(), kNotPatchable);
ASSERT(index == kBreakpointRuntimeCPIndex);
} else {
- object_pool_.Add(Object::null_object(), Heap::kOld);
+ object_pool_.Add(vacant, Heap::kOld);
patchable_pool_entries_.Add(kNotPatchable);
}
}

Powered by Google App Engine
This is Rietveld 408576698