Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: runtime/vm/object.cc

Issue 25813002: - Rename arrays to lists: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
===================================================================
--- runtime/vm/object.cc (revision 28179)
+++ runtime/vm/object.cc (working copy)
@@ -154,7 +154,7 @@
V(CoreLibrary, Object, _noSuchMethod) \
V(CoreLibrary, Object, _as) \
V(CoreLibrary, Object, _instanceOf) \
- V(CoreLibrary, _ObjectArray, _ObjectArray.) \
+ V(CoreLibrary, _List, _List.) \
srdjan 2013/10/03 00:13:31 Formatting
V(CoreLibrary, AssertionError, _throwNew) \
V(CoreLibrary, TypeError, _throwNew) \
V(CoreLibrary, FallThroughError, _throwNew) \
@@ -696,7 +696,7 @@
// Set up names for object array and one byte string class which are
// pre-allocated in the vm isolate also.
cls = Dart::vm_isolate()->object_store()->array_class();
- cls.set_name(Symbols::ObjectArray());
+ cls.set_name(Symbols::_List());
cls = Dart::vm_isolate()->object_store()->one_byte_string_class();
cls.set_name(Symbols::OneByteString());
}
@@ -876,7 +876,7 @@
// remaining classes and register them by name in the dictionaries.
String& name = String::Handle();
cls = object_store->array_class(); // Was allocated above.
- RegisterPrivateClass(cls, Symbols::ObjectArray(), core_lib);
+ RegisterPrivateClass(cls, Symbols::_List(), core_lib);
pending_classes.Add(cls);
// We cannot use NewNonParameterizedType(cls), because Array is parameterized.
type ^= Type::New(Object::Handle(cls.raw()),
@@ -887,7 +887,7 @@
object_store->set_array_type(type);
cls = object_store->growable_object_array_class(); // Was allocated above.
- RegisterPrivateClass(cls, Symbols::GrowableObjectArray(), core_lib);
+ RegisterPrivateClass(cls, Symbols::_GrowableList(), core_lib);
pending_classes.Add(cls);
cls = Class::New<Array>(kImmutableArrayCid);
@@ -895,7 +895,7 @@
cls.set_type_arguments_field_offset(Array::type_arguments_offset());
ASSERT(object_store->immutable_array_class() != object_store->array_class());
cls.set_is_prefinalized();
- RegisterPrivateClass(cls, Symbols::ImmutableArray(), core_lib);
+ RegisterPrivateClass(cls, Symbols::_ImmutableList(), core_lib);
pending_classes.Add(cls);
cls = object_store->one_byte_string_class(); // Was allocated above.
@@ -14320,10 +14320,10 @@
const char* Array::ToCString() const {
if (IsNull()) {
- return IsImmutable() ? "ImmutableArray NULL" : "Array NULL";
+ return IsImmutable() ? "_ImmutableList NULL" : "_List NULL";
}
- const char* format = !IsImmutable() ? "Array len:%" Pd "" :
- "Immutable Array len:%" Pd "";
+ const char* format = IsImmutable() ?
+ "_ImmutableList len:%" Pd : "_List len:%" Pd;
intptr_t len = OS::SNPrint(NULL, 0, format, Length()) + 1;
char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
OS::SNPrint(chars, len, format, Length());
@@ -14531,9 +14531,9 @@
const char* GrowableObjectArray::ToCString() const {
if (IsNull()) {
- return "GrowableObjectArray NULL";
+ return "_GrowableList NULL";
}
- const char* format = "GrowableObjectArray len:%" Pd "";
+ const char* format = "_GrowableList len:%" Pd "";
intptr_t len = OS::SNPrint(NULL, 0, format, Length()) + 1;
char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
OS::SNPrint(chars, len, format, Length());
« no previous file with comments | « runtime/vm/intrinsifier_x64.cc ('k') | runtime/vm/symbols.h » ('j') | runtime/vm/symbols.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698