Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2581243004: Pass main thread responsiveness threshold via Finch (Closed)
Patch Set: Use EXPECT_FALSE/TRUE - avoids compile error. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index cb4938dc6b74f1baa9047d51c1c9c05ee59111f0..5faa5e1deb8bc9e4cd328d69779f63b6291e6801 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -47,9 +47,6 @@ constexpr base::TimeDelta kThreadLoadTrackerWaitingPeriodBeforeReporting =
// We do not throttle anything while audio is played and shortly after that.
constexpr base::TimeDelta kThrottlingDelayAfterAudioIsPlayed =
base::TimeDelta::FromSeconds(5);
-// Maximum task queueing time before the main thread is considered unresponsive.
-constexpr base::TimeDelta kMainThreadResponsivenessThreshold =
- base::TimeDelta::FromMilliseconds(200);
void ReportForegroundRendererTaskLoad(base::TimeTicks time, double load) {
int load_percentage = static_cast<int>(load * 100);
@@ -114,7 +111,6 @@ RendererSchedulerImpl::RendererSchedulerImpl(
helper_.scheduler_tqm_delegate().get(),
helper_.scheduler_tqm_delegate()->NowTicks()),
policy_may_need_update_(&any_thread_lock_),
- main_thread_responsiveness_threshold_(kMainThreadResponsivenessThreshold),
weak_factory_(this) {
task_queue_throttler_.reset(
new TaskQueueThrottler(this, "renderer.scheduler"));
@@ -1623,7 +1619,8 @@ void RendererSchedulerImpl::SetRAILModeObserver(RAILModeObserver* observer) {
MainThreadOnly().rail_mode_observer = observer;
}
-bool RendererSchedulerImpl::MainThreadSeemsUnresponsive() {
+bool RendererSchedulerImpl::MainThreadSeemsUnresponsive(
+ base::TimeDelta main_thread_responsiveness_threshold) {
base::TimeTicks now = tick_clock()->NowTicks();
base::TimeDelta estimated_queueing_time;
@@ -1651,7 +1648,7 @@ bool RendererSchedulerImpl::MainThreadSeemsUnresponsive() {
queueing_time_estimator.EstimateQueueingTimeIncludingCurrentTask(now);
bool main_thread_seems_unresponsive =
- estimated_queueing_time > main_thread_responsiveness_threshold_;
+ estimated_queueing_time > main_thread_responsiveness_threshold;
CompositorThreadOnly().main_thread_seems_unresponsive =
main_thread_seems_unresponsive;

Powered by Google App Engine
This is Rietveld 408576698