components/content_settings/core/browser/cookie_settings_unittest.cc - Issue 2581213002: Force HostContentSettingsMap to be destroyed on its owning thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/cookie_settings_unittest.cc

Issue 2581213002: Force HostContentSettingsMap to be destroyed on its owning thread. (Closed)

Patch Set: s/STRH comparison/RunsTasksOnCurrentThread/ Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification_permission_context_unittest.cc ('k') | components/content_settings/core/browser/host_content_settings_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/cookie_settings_unittest.cc

diff --git a/components/content_settings/core/browser/cookie_settings_unittest.cc b/components/content_settings/core/browser/cookie_settings_unittest.cc

index fd9e1dbb47c36dc7f82be7b9db3ab7079e347a6e..2299b95802a562e3d516c3251798c7ebf201f89b 100644

--- a/components/content_settings/core/browser/cookie_settings_unittest.cc

+++ b/components/content_settings/core/browser/cookie_settings_unittest.cc

@@ -4,6 +4,7 @@

#include "components/content_settings/core/browser/cookie_settings.h"

+#include "base/message_loop/message_loop.h"

#include "components/content_settings/core/browser/host_content_settings_map.h"

#include "components/content_settings/core/common/content_settings_pattern.h"

#include "components/content_settings/core/common/pref_names.h"

@@ -38,6 +39,10 @@ class CookieSettingsTest : public testing::Test {

~CookieSettingsTest() override { settings_map_->ShutdownOnUIThread(); }

protected:

+ // There must be a valid ThreadTaskRunnerHandle in HostContentSettingsMap's

+ // scope.

+ base::MessageLoop message_loop_;

sync_preferences::TestingPrefServiceSyncable prefs_;

scoped_refptr<HostContentSettingsMap> settings_map_;

scoped_refptr<CookieSettings> cookie_settings_;