Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(948)

Unified Diff: ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js

Issue 2581133002: Quick View: Show year recorded metadata. (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
diff --git a/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js b/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
index 0f1b8f32e88bd241c1a18850a0ac9e210dbd646b..c249647d3e080e0ea0a508ce6b9a4906e5ea8b61 100644
--- a/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
+++ b/ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js
@@ -65,6 +65,7 @@ ContentMetadataProvider.PROPERTY_NAMES = [
'mediaMimeType',
'mediaTitle',
'mediaTrack',
+ 'mediaYearRecorded',
];
/**
@@ -162,7 +163,9 @@ ContentMetadataProvider.prototype.getFromMediaGalleries_ =
entry.file(function(blob) {
var metadataType = 'mimeTypeOnly';
if (names.indexOf('mediaArtist') !== -1 ||
- names.indexOf('mediaTitle') !== -1) {
+ names.indexOf('mediaTitle') !== -1 ||
+ names.indexOf('mediaTrack') !== -1 ||
+ names.indexOf('mediaYearRecorded') !== -1) {
metadataType = 'mimeTypeAndTags';
}
if (names.indexOf('contentThumbnailUrl') !== -1) {
@@ -314,7 +317,23 @@ ContentMetadataProvider.prototype.convertMediaMetadataToMetadataItem_ =
item.mediaDuration = metadata['duration'];
item.mediaGenre = metadata['genre'];
item.mediaTitle = metadata['title'];
- item.mediaTrack = metadata['track'];
+ if (metadata['track']) {
+ item.mediaTrack = '' + metadata['track'];
+ }
+ if (metadata.rawTags) {
+ metadata.rawTags.forEach(function(entry) {
+ if (entry.type === 'mp3') {
+ if (entry.tags['date']) {
+ item.mediaYearRecorded = entry.tags['date'];
+ }
+ // It is possible that metadata['track'] is undefined but this is
+ // defined.
+ if (entry.tags['track']) {
+ item.mediaTrack = entry.tags['track'];
+ }
+ }
+ });
+ }
if (metadata.attachedImages && metadata.attachedImages.length > 0) {
var reader = new FileReader();
reader.onload = function(e) {

Powered by Google App Engine
This is Rietveld 408576698