third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp - Issue 2581083003: Initial OpenType Font Variations Support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

Issue 2581083003: Initial OpenType Font Variations Support (Closed)

Patch Set: Fix hash collision tests, adjust test expectations Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

index 1e5daf32a167daaec3c90cf18686656a852d7607..a364f530a2c874469c940f6c9987067c2e6c9016 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp

@@ -386,6 +386,9 @@ hb_font_t* HarfBuzzFace::getScaledFont(

m_harfBuzzFontData->m_paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding);

m_harfBuzzFontData->m_rangeSet = rangeSet;

m_harfBuzzFontData->updateSimpleFontData(m_platformData);

+ // TODO crbug.com/674879 - Connect variation axis parameters to future

+ // HarfBuzz API here.

ASSERT(m_harfBuzzFontData->m_simpleFontData);

int scale = SkiaScalarToHarfBuzzPosition(m_platformData->size());

hb_font_set_scale(m_unscaledFont, scale, scale);