Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp

Issue 2581083003: Initial OpenType Font Variations Support (Closed)
Patch Set: Fix hash collision tests, adjust test expectations Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp b/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
index d6b97cd849c1b0ea916abf1f3b5612115183e958..fcc5e56b32da3d94eb65c850ec1b2e128a87cc52 100644
--- a/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
+++ b/third_party/WebKit/Source/platform/fonts/linux/FontPlatformDataLinux.cpp
@@ -45,6 +45,12 @@ void FontPlatformData::setupPaint(SkPaint* paint,
paint->setTypeface(m_typeface);
paint->setFakeBoldText(m_syntheticBold);
paint->setTextSkewX(m_syntheticItalic ? -SK_Scalar1 / 4 : 0);
+
+ // TODO(drott): Due to Skia bug 5917
+ // https://bugs.chromium.org/p/skia/issues/detail?id=5917 correct advance
+ // width scaling with FreeType for font sizes under 257px currently only works
+ // with:
+ // paint->setHinting(SkPaint::kNo_Hinting);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698