third_party/WebKit/LayoutTests/fast/text/variable-fonts/variable-mac-system-font.html - Issue 2581083003: Initial OpenType Font Variations Support

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/text/variable-fonts/variable-mac-system-font.html

Issue 2581083003: Initial OpenType Font Variations Support (Closed)

Patch Set: Fix Windows compilation by avoiding VLA Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <script src="../../../resources/testharness.js"></script>

	4 <script src="../../../resources/testharnessreport.js"></script>

	5 <script>

	6 setup({ explicit_done: true });

	7 window.onload = () => {
	eae 2016/12/16 18:48:27 I don't think you need to use an onload handler he I don't think you need to use an onload handler here. If you move the script block down to the end of the body it should work as a regular synchronous test. That'll make it faster and a little easier to debug. drott 2016/12/19 14:12:34 Moved to end, no onload handler. Show quoted text On 2016/12/16 at 18:48:27, eae (ooo until 2017-01-03) wrote: > I don't think you need to use an onload handler here. If you move the script block down to the end of the body it should work as a regular synchronous test. That'll make it faster and a little easier to debug. Moved to end, no onload handler.
	8 test(function() { assert_true(narrow.getBoundingClientRect().width <

	9 wide.getBoundingClientRect().width * 0.6); },

	10 "Narrow Skia variation is less than 60% as wide.");

	11 done();

	12 };

	13 </script>

	14 <style>

	15 .variation {

	16 font-family: Skia, sans-serif;

	17 font-size: 150px;

	18 }

	19

	20 #narrow {

	21 font-variation-settings: "wdth" 0.61998;

	22 }

	23

	24 #wide {

	25 font-variation-settings: "wdth" 1.29999;

	26 }

	27 </style>

	28 <span class="variation" id="narrow">wwwwide</span><br>

	29 <span class="variation" id="wide">wwwwide</span>

OLD	NEW