components/subresource_filter/core/browser/subresource_filter_features_test_support.cc - Issue 2581043003: Add page-level aggregation of SubresourceFilter time metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

Issue 2581043003: Add page-level aggregation of SubresourceFilter time metrics. (Closed)

Patch Set: Address comments of engedy@ and add tests. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc ('K') | « components/subresource_filter/content/renderer/subresource_filter_agent_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

diff --git a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

index 78d2c484a5d7607255c432da06e933165cb68b65..a6be80b0d30d0034a1823f4a06c65b0277356541 100644

--- a/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

+++ b/components/subresource_filter/core/browser/subresource_filter_features_test_support.cc

@@ -16,8 +16,8 @@ namespace subresource_filter {

namespace testing {

namespace {

-const char kTestFieldTrialName[] = "FieldTrialNameShouldNotMatter";

-const char kTestExperimentGroupName[] = "GroupNameShouldNotMatter";

+constexpr const char kTestFieldTrialName[] = "FieldTrialNameShouldNotMatter";

+constexpr const char kTestExperimentGroupName[] = "GroupNameShouldNotMatter";

} // namespace

ScopedSubresourceFilterFeatureToggle::ScopedSubresourceFilterFeatureToggle(