Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: components/subresource_filter/content/common/subresource_filter_messages.h

Issue 2581043003: Add page-level aggregation of SubresourceFilter time metrics. (Closed)
Patch Set: Address comments of engedy@ and add tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/common/subresource_filter_messages.h
diff --git a/components/subresource_filter/content/common/subresource_filter_messages.h b/components/subresource_filter/content/common/subresource_filter_messages.h
index a817c61af3772817b7937f7287dd82d2201a10f5..1b7e13b9ebecddfa55f9c548ee60d55470f295d2 100644
--- a/components/subresource_filter/content/common/subresource_filter_messages.h
+++ b/components/subresource_filter/content/common/subresource_filter_messages.h
@@ -4,6 +4,7 @@
// Message definition file, included multiple times, hence no include guard.
+#include "base/time/time.h"
#include "components/subresource_filter/core/common/activation_state.h"
#include "content/public/common/common_param_traits_macros.h"
#include "ipc/ipc_message_macros.h"
@@ -42,4 +43,12 @@ IPC_MESSAGE_ROUTED3(SubresourceFilterMsg_ActivateForProvisionalLoad,
// Sent to the browser the first time a subresource load is disallowed for the
// most recently commited document load in a frame. It is used to trigger a
// UI prompt to inform the user and allow them to turn off filtering.
-IPC_MESSAGE_ROUTED0(SubresourceFilterHostMsg_DidDisallowFirstSubresource)
+IPC_MESSAGE_ROUTED0(SubresourceFilterHostMsg_DidDisallowFirstSubresource);
+
+// This is sent to a RenderFrameHost in the browser when a document load is
+// finished, just before the DidFinishLoad message, if performance measurements
+// were enabled for the load. Contains total time spent on evaluating
engedy 2016/12/21 19:10:28 nit: the total
pkalinnikov 2016/12/22 16:53:04 Done.
+// subresource loads in DocumentSubresourceFilter::allowLoad() for a frame.
+IPC_MESSAGE_ROUTED2(SubresourceFilterHostMsg_DocumentLoadStatistics,
+ base::TimeDelta /* evaluation_total_wall_duration */,
+ base::TimeDelta /* evaluation_total_cpu_duration */);

Powered by Google App Engine
This is Rietveld 408576698