components/subresource_filter/content/common/subresource_filter_messages.h - Issue 2581043003: Add page-level aggregation of SubresourceFilter time metrics.

Unified Diff: components/subresource_filter/content/common/subresource_filter_messages.h

Issue 2581043003: Add page-level aggregation of SubresourceFilter time metrics. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc ('K') | « components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc ('k') | components/subresource_filter/content/renderer/subresource_filter_agent.cc » ('j') | components/subresource_filter/content/renderer/subresource_filter_agent.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/common/subresource_filter_messages.h

diff --git a/components/subresource_filter/content/common/subresource_filter_messages.h b/components/subresource_filter/content/common/subresource_filter_messages.h

index a817c61af3772817b7937f7287dd82d2201a10f5..f9a066f3ee29f84023767761f5b70714985bb616 100644

--- a/components/subresource_filter/content/common/subresource_filter_messages.h

+++ b/components/subresource_filter/content/common/subresource_filter_messages.h

@@ -4,6 +4,7 @@

// Message definition file, included multiple times, hence no include guard.

+#include "base/time/time.h"

#include "components/subresource_filter/core/common/activation_state.h"

#include "content/public/common/common_param_traits_macros.h"

#include "ipc/ipc_message_macros.h"

@@ -42,4 +43,11 @@ IPC_MESSAGE_ROUTED3(SubresourceFilterMsg_ActivateForProvisionalLoad,

// Sent to the browser the first time a subresource load is disallowed for the

engedy 2016/12/19 10:18:42 Should mention here that this is sent when a docum

pkalinnikov 2016/12/21 15:28:46 Done. I assume, that you meant not here but below.

engedy 2016/12/21 19:10:28 Acknowledged.

// most recently commited document load in a frame. It is used to trigger a

// UI prompt to inform the user and allow them to turn off filtering.

-IPC_MESSAGE_ROUTED0(SubresourceFilterHostMsg_DidDisallowFirstSubresource)

+IPC_MESSAGE_ROUTED0(SubresourceFilterHostMsg_DidDisallowFirstSubresource);

+// Sent to a RenderFrameHost in the browser when SubresourceFilterAgent has

+// aggregated total time spent in DocumentSubresourceFilter::allowLoad() while

+// evaluating subresource loads for a (sub-)frame.

+IPC_MESSAGE_ROUTED2(SubresourceFilterHostMsg_DidAggregateEvaluationDuration,

engedy 2016/12/19 10:18:42 What do you think about: _DocumentLoadStatistics

pkalinnikov 2016/12/21 15:28:46 Done.

+ base::TimeDelta /* evaluation_total_wall_duration */,

+ base::TimeDelta /* evaluation_total_cpu_duration */);