tools/metrics/histograms/histograms.xml - Issue 2581043003: Add page-level aggregation of SubresourceFilter time metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2581043003: Add page-level aggregation of SubresourceFilter time metrics. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 11ae958f7a0f39ca8f319a4afb6316f184005c50..1dbfa06b08bc3dd644704a6167e1487a60190c74 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -64358,6 +64358,29 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram

+ name="SubresourceFilter.PageLoad.SubresourceEvaluation.TotalCPUDuration"

+ units="microseconds">

+ <owner>pkalinnikov@chromium.org</owner>

+ <summary>

+ Whenever a page load is finished with subresource filtering activated,

+ records the total thread CPU time spent by dependent

+ DocumentSubresourceFilters on processing subresource requests in allowLoad.

engedy 2016/12/19 10:18:42 Phrasing nit (same below): ... spent on evaluatin

pkalinnikov 2016/12/21 15:28:46 Done.

+ </summary>

+</histogram>

+<histogram

+ name="SubresourceFilter.PageLoad.SubresourceEvaluation.TotalWallDuration"

+ units="microseconds">

+ <owner>pkalinnikov@chromium.org</owner>

+ <summary>

+ Whenever a page load is finished with subresource filtering activated,

+ records the total real time spent by dependent DocumentSubresourceFilters on

+ processing subresource requests in allowLoad, including the time spent on

+ waiting or being descheduled.

+ </summary>

+</histogram>

<owner>melandory@chromium.org</owner>