Add tab status to accessibility labels

chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/tabs/browser_tab_strip_controller.h"
 
 #include "base/auto_reset.h"
 #include "base/macros.h"
 #include "base/task_runner_util.h"
 #include "base/threading/sequenced_worker_pool.h"
@@ skipping 16 matching lines @@
 #include "chrome/browser/ui/views/tabs/tab_renderer_data.h"
 #include "chrome/browser/ui/views/tabs/tab_strip.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/metrics/proto/omnibox_event.pb.h"
 #include "components/mime_util/mime_util.h"
 #include "components/omnibox/browser/autocomplete_classifier.h"
 #include "components/omnibox/browser/autocomplete_match.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/navigation_controller.h"
+#include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/plugin_service.h"
 #include "content/public/browser/user_metrics.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/webplugininfo.h"
 #include "ipc/ipc_message.h"
 #include "net/base/filename_util.h"
 #include "ui/base/models/list_selection_model.h"
 #include "ui/gfx/image/image.h"
 #include "ui/views/controls/menu/menu_runner.h"
 #include "ui/views/widget/widget.h"
 #include "url/origin.h"
 
 using base::UserMetricsAction;
 using content::WebContents;
 
 namespace {
 
 TabRendererData::NetworkState TabContentsNetworkState(
     WebContents* contents) {
-  if (!contents || !contents->IsLoadingToDifferentDocument())
+  if (!contents)
     return TabRendererData::NETWORK_STATE_NONE;
+
+  if (!contents->IsLoadingToDifferentDocument()) {
+    content::NavigationEntry* entry =
+        contents->GetController().GetLastCommittedEntry();
+    if (entry && (entry->GetPageType() == content::PAGE_TYPE_ERROR))
+      return TabRendererData::NETWORK_STATE_ERROR;
+    return TabRendererData::NETWORK_STATE_NONE;
+  }
+
   if (contents->IsWaitingForResponse())
     return TabRendererData::NETWORK_STATE_WAITING;
   return TabRendererData::NETWORK_STATE_LOADING;
 }
 
 bool DetermineTabStripLayoutStacked(PrefService* prefs, bool* adjust_layout) {
   *adjust_layout = false;
   // For ash, always allow entering stacked mode.
 #if defined(USE_ASH)
   *adjust_layout = true;
@@ skipping 344 matching lines @@
       base::Bind(&BrowserTabStripController::OnFindURLMimeTypeCompleted,
                  weak_ptr_factory_.GetWeakPtr(),
                  url));
 }
 
 SkColor BrowserTabStripController::GetToolbarTopSeparatorColor() const {
   return BrowserView::GetBrowserViewForBrowser(browser_)->frame()
       ->GetFrameView()->GetToolbarTopSeparatorColor();
 }
 
+base::string16 BrowserTabStripController::GetAccessibleTabName() const {
+  return BrowserView::GetBrowserViewForBrowser(browser_)

[sky, 2016/12/16 00:52:51]

Can you change BrowserTabStripController to take a BrowserView? Less lookup
then.

Do all tabs really share the same accessible name? Shouldn't the name be
specific to the tab?

[edwardjung, 2016/12/19 12:59:25]

Good point, fixed.

+      ->GetAccessibleWindowTitle();
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserTabStripController, TabStripModelObserver implementation:
 
 void BrowserTabStripController::TabInsertedAt(TabStripModel* tab_strip_model,
                                               WebContents* contents,
                                               int model_index,
                                               bool is_active) {
   DCHECK(contents);
   DCHECK(model_->ContainsIndex(model_index));
   AddTab(contents, model_index, is_active);
@@ skipping 138 matching lines @@
   content::WebPluginInfo plugin;
   tabstrip_->FileSupported(
       url,
       mime_type.empty() || mime_util::IsSupportedMimeType(mime_type) ||
           content::PluginService::GetInstance()->GetPluginInfo(
               -1,                // process ID
               MSG_ROUTING_NONE,  // routing ID
               model_->profile()->GetResourceContext(), url, url::Origin(),
               mime_type, false, NULL, &plugin, NULL));
 }