Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: pkg/analyzer_cli/lib/src/options.dart

Issue 2580933002: refactor DDC and Analyzer CLI parser option declaration (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer_cli/lib/src/options.dart
diff --git a/pkg/analyzer_cli/lib/src/options.dart b/pkg/analyzer_cli/lib/src/options.dart
index 7e6afab73f1597d9087f1d8c3e1a6f8310d0d888..2b75a64825abc32a08542423a3e8a618f50ea59e 100644
--- a/pkg/analyzer_cli/lib/src/options.dart
+++ b/pkg/analyzer_cli/lib/src/options.dart
@@ -280,25 +280,14 @@ class CommandLineOptions {
bool verbose = args.contains('-v') || args.contains('--verbose');
bool hide = !verbose;
- var parser = new ArgParser(allowTrailingOptions: true)
+ var parser = new ArgParser(allowTrailingOptions: true);
+ defineAnalysisArguments(parser, hide: hide);
+ parser
..addFlag('batch',
abbr: 'b',
help: 'Read commands from standard input (for testing).',
defaultsTo: false,
negatable: false)
- ..addOption('dart-sdk', help: 'The path to the Dart SDK.')
- ..addOption('dart-sdk-summary',
- help: 'The path to the Dart SDK summary file.', hide: true)
- ..addOption('packages',
- help:
- 'Path to the package resolution configuration file, which supplies '
- 'a mapping of package names to paths. This option cannot be '
- 'used with --package-root.')
- ..addOption('package-root',
- abbr: 'p',
- help: 'Path to a package root directory (deprecated). This option '
- 'cannot be used with --packages.')
- ..addOption('options', help: 'Path to an analysis options file.')
..addOption('format',
help: 'Specifies the format in which errors are displayed.')
..addFlag('machine',
@@ -445,27 +434,11 @@ class CommandLineOptions {
defaultsTo: false,
negatable: false,
hide: hide)
- ..addFlag('enable-strict-call-checks',
- help: 'Fix issue 21938.',
- defaultsTo: false,
- negatable: false,
- hide: hide)
..addFlag('enable-new-task-model',
help: 'deprecated -- Ennable new task model.',
defaultsTo: false,
negatable: false,
hide: hide)
- ..addFlag('initializing-formal-access',
- help:
- 'Enable support for allowing access to field formal parameters in a constructor\'s initializer list',
- defaultsTo: false,
- negatable: false,
- hide: hide)
- ..addFlag('supermixin',
- help: 'Relax restrictions on mixins (DEP 34).',
- defaultsTo: false,
- negatable: false,
- hide: hide)
..addFlag('log',
help: 'Log additional messages and exceptions.',
defaultsTo: false,
@@ -475,15 +448,7 @@ class CommandLineOptions {
help: 'Check types in constant evaluation.',
defaultsTo: false,
negatable: false,
- hide: hide)
- ..addFlag('strong',
- help: 'Enable strong static checks (https://goo.gl/DqcBsw)')
- ..addFlag('no-implicit-casts',
- negatable: false,
- help: 'Disable implicit casts in strong mode (https://goo.gl/cTLz40)')
- ..addFlag('no-implicit-dynamic',
- negatable: false,
- help: 'Disable implicit dynamic (https://goo.gl/m0UgXD)');
+ hide: hide);
try {
// TODO(scheglov) https://code.google.com/p/dart/issues/detail?id=11061

Powered by Google App Engine
This is Rietveld 408576698