Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2580933002: refactor DDC and Analyzer CLI parser option declaration (Closed)

Created:
4 years ago by danrubel
Modified:
4 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -63 lines) Patch
M pkg/analyzer/lib/src/command_line/arguments.dart View 2 chunks +30 lines, -18 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 3 chunks +4 lines, -39 lines 0 comments Download
M pkg/dev_compiler/lib/src/analyzer/context.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/command.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
danrubel
4 years ago (2016-12-15 18:51:02 UTC) #2
Brian Wilkerson
lgtm https://codereview.chromium.org/2580933002/diff/1/pkg/analyzer/lib/src/command_line/arguments.dart File pkg/analyzer/lib/src/command_line/arguments.dart (right): https://codereview.chromium.org/2580933002/diff/1/pkg/analyzer/lib/src/command_line/arguments.dart#newcode162 pkg/analyzer/lib/src/command_line/arguments.dart:162: * and remove this method. That should be ...
4 years ago (2016-12-15 18:58:40 UTC) #3
danrubel
https://codereview.chromium.org/2580933002/diff/1/pkg/analyzer/lib/src/command_line/arguments.dart File pkg/analyzer/lib/src/command_line/arguments.dart (right): https://codereview.chromium.org/2580933002/diff/1/pkg/analyzer/lib/src/command_line/arguments.dart#newcode162 pkg/analyzer/lib/src/command_line/arguments.dart:162: * and remove this method. On 2016/12/15 18:58:40, Brian ...
4 years ago (2016-12-15 19:02:42 UTC) #4
Brian Wilkerson
That's likely to be more than one step :-)
4 years ago (2016-12-15 19:09:43 UTC) #5
danrubel
4 years ago (2016-12-15 19:10:14 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a105d89e2b07a1799366982db1b3f37b27f37af0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698