cc: Record statistics about approximated content.

cc: Record statistics about approximated content.

Record the total visible content area and the approximated visible content
area. Approximated area is the visible area covered by low-res or missing tiles.
These statistics will be used in a follow-up patch to report the percentage of
pixels that were approximated in smoothness benchmark.

R=vmpstr@chromium.org,enne@chromium.org,
BUG=308652
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267088

[ernstm, 2014-04-29 00:01:08]

PTAL

[enne (OOO), 2014-04-29 17:38:41]

https://codereview.chromium.org/258093005/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/258093005/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.cc:331: if (iter->priority(ACTIVE_TREE).resolution
== LOW_RESOLUTION) {
This is not entirely right.  You could be using a non ideal resolution tile of a
scale less than high resolution too.

[ernstm, 2014-04-29 18:40:13]

https://codereview.chromium.org/258093005/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/258093005/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.cc:331: if (iter->priority(ACTIVE_TREE).resolution
== LOW_RESOLUTION) {
On 2014/04/29 17:38:41, enne wrote:
> This is not entirely right.  You could be using a non ideal resolution tile of
a
> scale less than high resolution too.

I changed this to != HIGH_RESOLUTION. That should capture all approximated
cases, right?

[enne (OOO), 2014-04-29 18:46:37]

https://codereview.chromium.org/258093005/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/258093005/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.cc:331: if (iter->priority(ACTIVE_TREE).resolution
== LOW_RESOLUTION) {
On 2014/04/29 18:40:14, ernstm wrote:
> On 2014/04/29 17:38:41, enne wrote:
> > This is not entirely right.  You could be using a non ideal resolution tile
of
> a
> > scale less than high resolution too.
> 
> I changed this to != HIGH_RESOLUTION. That should capture all approximated
> cases, right?

You can sometimes have a non-ideal resolution that's higher than high resolution
in the case of a zoom in.  I'd call that not approximated, but it's up to you.

[ernstm, 2014-04-29 19:00:12]

https://codereview.chromium.org/258093005/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (right):

https://codereview.chromium.org/258093005/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.cc:331: if (iter->priority(ACTIVE_TREE).resolution
== LOW_RESOLUTION) {
On 2014/04/29 18:46:38, enne wrote:
> On 2014/04/29 18:40:14, ernstm wrote:
> > On 2014/04/29 17:38:41, enne wrote:
> > > This is not entirely right.  You could be using a non ideal resolution
tile
> of
> > a
> > > scale less than high resolution too.
> > 
> > I changed this to != HIGH_RESOLUTION. That should capture all approximated
> > cases, right?
> 
> You can sometimes have a non-ideal resolution that's higher than high
resolution
> in the case of a zoom in.  I'd call that not approximated, but it's up to you.

I assume we need to resample/interpolate in that case, which can result in
artifacts. It's not really an approximation, but it is different than the ideal
result.

[enne (OOO), 2014-04-29 19:02:48]

lgtm

[ernstm, 2014-04-29 19:18:05]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-04-29 19:19:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ernstm@chromium.org/258093005/20001

[commit-bot: I haz the power, 2014-04-30 05:29:25]

Change committed as 267088