Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: chrome/browser/ui/auto_login_infobar_delegate.h

Issue 258093003: Fix Android not tracking all AutoLogin metrics. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix styling nit Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/auto_login_infobar_delegate.h
diff --git a/chrome/browser/ui/auto_login_infobar_delegate.h b/chrome/browser/ui/auto_login_infobar_delegate.h
index 5064b06c90254ec4ff3812a55321773ad4968833..7c32e427999720d15a74e63e332011507358a493 100644
--- a/chrome/browser/ui/auto_login_infobar_delegate.h
+++ b/chrome/browser/ui/auto_login_infobar_delegate.h
@@ -38,10 +38,6 @@ class AutoLoginInfoBarDelegate : public ConfirmInfoBarDelegate,
static bool Create(content::WebContents* web_contents, const Params& params);
protected:
- AutoLoginInfoBarDelegate(const Params& params, Profile* profile);
- virtual ~AutoLoginInfoBarDelegate();
-
- private:
// Enum values used for UMA histograms.
enum Actions {
SHOWN, // The infobar was shown to the user.
@@ -53,6 +49,12 @@ class AutoLoginInfoBarDelegate : public ConfirmInfoBarDelegate,
HISTOGRAM_BOUNDING_VALUE
};
+ AutoLoginInfoBarDelegate(const Params& params, Profile* profile);
+ virtual ~AutoLoginInfoBarDelegate();
+
+ void RecordHistogramAction(Actions action);
+
+ private:
// ConfirmInfoBarDelegate:
virtual void InfoBarDismissed() OVERRIDE;
virtual int GetIconID() const OVERRIDE;
@@ -66,8 +68,6 @@ class AutoLoginInfoBarDelegate : public ConfirmInfoBarDelegate,
// SigninManagerBase::Observer:
virtual void GoogleSignedOut(const std::string& username) OVERRIDE;
- void RecordHistogramAction(Actions action);
-
const Params params_;
Profile* profile_;

Powered by Google App Engine
This is Rietveld 408576698