Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 258093003: Fix Android not tracking all AutoLogin metrics. (Closed)

Created:
6 years, 7 months ago by Ted C
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix Android not tracking all AutoLogin metrics. Android's delegate overrides Accept/Cancel and does not record all the necessary histogram actions. BUG=329200 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266772

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix styling nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M chrome/browser/ui/android/infobars/auto_login_infobar_delegate_android.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/auto_login_infobar_delegate.h View 1 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/auto_login_infobar_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ted C
@pkasting PTAL @miguelg, I think it was easier to write the change than reassign the ...
6 years, 7 months ago (2014-04-28 21:25:04 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/258093003/diff/1/chrome/browser/ui/auto_login_infobar_delegate.h File chrome/browser/ui/auto_login_infobar_delegate.h (right): https://codereview.chromium.org/258093003/diff/1/chrome/browser/ui/auto_login_infobar_delegate.h#newcode54 chrome/browser/ui/auto_login_infobar_delegate.h:54: void RecordHistogramAction(Actions action); Nit: Blank line above this
6 years, 7 months ago (2014-04-28 21:28:33 UTC) #2
Ted C
https://codereview.chromium.org/258093003/diff/1/chrome/browser/ui/auto_login_infobar_delegate.h File chrome/browser/ui/auto_login_infobar_delegate.h (right): https://codereview.chromium.org/258093003/diff/1/chrome/browser/ui/auto_login_infobar_delegate.h#newcode54 chrome/browser/ui/auto_login_infobar_delegate.h:54: void RecordHistogramAction(Actions action); On 2014/04/28 21:28:33, Peter Kasting wrote: ...
6 years, 7 months ago (2014-04-28 21:29:56 UTC) #3
Ted C
The CQ bit was checked by tedchoc@chromium.org
6 years, 7 months ago (2014-04-28 21:30:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/258093003/20001
6 years, 7 months ago (2014-04-28 21:32:12 UTC) #5
commit-bot: I haz the power
Change committed as 266772
6 years, 7 months ago (2014-04-29 07:40:15 UTC) #6
Miguel Garcia
6 years, 7 months ago (2014-04-29 08:09:21 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698