Chromium Code Reviews| Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js |
| diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js |
| index 33db9366dddff986388c37279e68bd3ee5feb46e..6146034c4b5b37f2956a198937b12fb6e8724faf 100644 |
| --- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js |
| +++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineLandingPage.js |
| @@ -36,30 +36,18 @@ Timeline.TimelineLandingPage = class extends UI.VBox { |
| this._tabbedPane.addEventListener(UI.TabbedPane.Events.TabSelected, this._tabSelected, this); |
| this._tabbedPane.show(this.contentElement); |
| - this._perspectiveSetting = |
| - Common.settings.createSetting('timelinePerspective', Timeline.TimelinePanel.Perspectives.Load); |
| - this._perspectiveSetting.addChangeListener(this._perspectiveChanged, this); |
| /** |
| * @return {!Element} |
| */ |
| function learnMore() { |
| return UI.createExternalLink( |
| - 'https://developers.google.com/web/tools/chrome-devtools/evaluate-performance/timeline-tool', |
| + 'https://developers.google.com/web/tools/chrome-devtools/evaluate-performance/', |
| Common.UIString('Learn more')); |
| } |
| } |
| - /** |
| - * @param {!Common.Event} event |
| - */ |
| - _tabSelected(event) { |
| - if (this._perspectiveSetting.get() !== event.data.tabId) |
| - this._perspectiveSetting.set(event.data.tabId); |
| - } |
| - |
| - _perspectiveChanged() { |
| - this._tabbedPane.selectTab(this._perspectiveSetting.get()); |
| + _tabSelected() { |
| const tabWidget = /** @type {!Timeline.TimelineLandingPage.PerspectiveTabWidget} */ (this._tabbedPane.visibleView); |
| tabWidget.activate(); |
| } |
| @@ -143,6 +131,6 @@ Timeline.TimelineLandingPage.PerspectiveTabWidget = class extends UI.VBox { |
| } |
| _recordPageLoad() { |
| - SDK.targetManager.reloadPage(); |
| + UI.actionRegistry.action('main.reload').execute(); |
|
caseq
2016/12/16 01:47:40
Please revert it, direct call is better when the d
alph
2016/12/16 01:59:55
Reverted this one. Will address another is a separ
|
| } |
| }; |