[test] Add more maybe-assigned tests for parameters.

test/cctest/test-parsing.cc

Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 7a35ebe469b394c52a734fd9a6b36a49ca9c61e3..c2b5a36f96738ca48ec12f672ff189fb07a1f6dc 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -3439,50 +3439,64 @@ TEST(MaybeAssignedParameters) {
 
   struct {
     bool arg_assigned;
+    bool imprecise_when_lazy;
     const char* source;
   } tests[] = {
-      {false, "function f(arg) {}"},
-      {false, "function f(arg) {g(arg)}"},
-      {false, "function f(arg) {function h() { g(arg) }; h()}"},
-      {false, "function f(arg) {function h() { g(arg) }; return h}"},
-      {false, "function f(arg=1) {}"},
-      {false, "function f(arg=1) {g(arg)}"},
-      {false, "function f(arg, arguments) {g(arg); arguments[0] = 42; g(arg)}"},
-      {false,
+      {false, false, "function f(arg) {}"},
+      {false, false, "function f(arg) {g(arg)}"},
+      {false, false, "function f(arg) {function h() { g(arg) }; h()}"},
+      {false, false, "function f(arg) {function h() { g(arg) }; return h}"},
+      {false, false, "function f(arg=1) {}"},
+      {false, false, "function f(arg=1) {g(arg)}"},
+      {false, false,
+       "function f(arg, arguments) {g(arg); arguments[0] = 42; g(arg)}"},
+      {false, false,
        "function f(arg, ...arguments) {g(arg); arguments[0] = 42; g(arg)}"},
-      {false,
+      {false, false,
        "function f(arg, arguments=[]) {g(arg); arguments[0] = 42; g(arg)}"},
-      {false, "function f(...arg) {g(arg); arguments[0] = 42; g(arg)}"},
+      {false, false, "function f(...arg) {g(arg); arguments[0] = 42; g(arg)}"},
+      {false, true,
+       "function f(arg) {g(arg); g(function() {arguments[0] = 42}); g(arg)}"},

[neis, 2016/12/16 10:12:54]

This test is the reason for adding the imprecise_when_lazy flag.

 
       // strict arguments object
-      {false, "function f(arg, x=1) {g(arg); arguments[0] = 42; g(arg)}"},
-      {false, "function f(arg, ...x) {g(arg); arguments[0] = 42; g(arg)}"},
-      {false, "function f(arg=1) {g(arg); arguments[0] = 42; g(arg)}"},
-      {false,
+      {false, false,
+       "function f(arg, x=1) {g(arg); arguments[0] = 42; g(arg)}"},
+      {false, false,
+       "function f(arg, ...x) {g(arg); arguments[0] = 42; g(arg)}"},
+      {false, false, "function f(arg=1) {g(arg); arguments[0] = 42; g(arg)}"},
+      {false, false,
        "function f(arg) {'use strict'; g(arg); arguments[0] = 42; g(arg)}"},
-      {false, "function f(arg) {g(arg); f.arguments[0] = 42; g(arg)}"},
-      {false, "function f(arg, args=arguments) {g(arg); args[0] = 42; g(arg)}"},
-
-      {true, "function f(arg) {g(arg); arg = 42; g(arg)}"},
-      {true, "function f(arg) {g(arg); eval('arg = 42'); g(arg)}"},
-      {true, "function f(arg) {g(arg); var arg = 42; g(arg)}"},
-      {true, "function f(arg, x=1) {g(arg); arg = 42; g(arg)}"},
-      {true, "function f(arg, ...x) {g(arg); arg = 42; g(arg)}"},
-      {true, "function f(arg=1) {g(arg); arg = 42; g(arg)}"},
-      {true, "function f(arg) {'use strict'; g(arg); arg = 42; g(arg)}"},
-      {true, "function f(arg, {a=(g(arg), arg=42)}) {g(arg)}"},
-      {true, "function f(arg) {g(arg); g(() => arg = 42); g(arg)}"},
-      {true, "function f(arg) {g(arg); g(() => eval('arg = 42')); g(arg)}"},
-      {true, "function f(arg) {g(arg); g(() => arguments[0] = 42); g(arg)}"},
-      {true, "function f(...arg) {g(arg); eval('arg = 42'); g(arg)}"},
+      {false, false, "function f(arg) {g(arg); f.arguments[0] = 42; g(arg)}"},
+      {false, false,
+       "function f(arg, args=arguments) {g(arg); args[0] = 42; g(arg)}"},
+
+      {true, false, "function f(arg) {g(arg); arg = 42; g(arg)}"},
+      {true, false, "function f(arg) {g(arg); eval('arg = 42'); g(arg)}"},
+      {true, false, "function f(arg) {g(arg); var arg = 42; g(arg)}"},
+      {true, false, "function f(arg, x=1) {g(arg); arg = 42; g(arg)}"},
+      {true, false, "function f(arg, ...x) {g(arg); arg = 42; g(arg)}"},
+      {true, false, "function f(arg=1) {g(arg); arg = 42; g(arg)}"},
+      {true, false, "function f(arg) {'use strict'; g(arg); arg = 42; g(arg)}"},
+      {true, false, "function f(arg, {a=(g(arg), arg=42)}) {g(arg)}"},
+      {true, false,
+       "function f(arg) {g(arg); g(function() {arg = 42}); g(arg)}"},
+      {true, false,
+       "function f(arg) {g(arg); g(function() {eval('arg = 42')}); g(arg)}"},
+      {true, false, "function f(arg) {g(arg); g(() => arg = 42); g(arg)}"},
+      {true, false,
+       "function f(arg) {g(arg); g(() => eval('arg = 42')); g(arg)}"},
+      {true, false, "function f(...arg) {g(arg); eval('arg = 42'); g(arg)}"},
 
       // sloppy arguments object
-      {true, "function f(arg) {g(arg); arguments[0] = 42; g(arg)}"},
-      {true, "function f(arg) {g(arg); h(arguments); g(arg)}"},
-      {true,
+      {true, false, "function f(arg) {g(arg); arguments[0] = 42; g(arg)}"},
+      {true, false, "function f(arg) {g(arg); h(arguments); g(arg)}"},
+      {true, false,
        "function f(arg) {((args) => {arguments[0] = 42})(arguments); "
        "g(arg)}"},
-      {true, "function f(arg) {g(arg); eval('arguments[0] = 42'); g(arg)}"},
+      {true, false,
+       "function f(arg) {g(arg); eval('arguments[0] = 42'); g(arg)}"},
+      {true, false,
+       "function f(arg) {g(arg); g(() => arguments[0] = 42); g(arg)}"},
   };
 
   const char* suffix = "; f";
@@ -3516,7 +3530,11 @@ TEST(MaybeAssignedParameters) {
       i::Variable* var = scope->Lookup(var_name);
       CHECK(var->is_used() || !assigned);
       bool is_maybe_assigned = var->maybe_assigned() == i::kMaybeAssigned;
-      CHECK_EQ(is_maybe_assigned, assigned);
+      if (allow_lazy && tests[i].imprecise_when_lazy) {
+        CHECK_IMPLIES(assigned, is_maybe_assigned);
+      } else {
+        CHECK_EQ(assigned, is_maybe_assigned);
+      }
     }
   }
 }