DescriptionRevert 266518 "Added collapsible permissions to the app info dialog"
Test doesn't work with tsan:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28TSan%20v2%29%281%29/builds/8850/steps/unit_tests/logs/RetainedFilePermissionsObtainedCorrectly
[ RUN ] AppInfoPermissionsTabTest.RetainedFilePermissionsObtainedCorrectly
../../chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc:193: Failure
Value of: retained_files[0]
Actual: 24-byte object \u003C14-66 69-6C 65-5F 33-2E 65-78 74-00 0C-7D 00-00 2B-00 00-00 00-00 00-00>
Expected: base::FilePath("file_1.ext")
Which is: 24-byte object \u003C14-66 69-6C 65-5F 31-2E 65-78 74-00 00-00 00-00 07-7A E9-08 02-00 00-00>
[ FAILED ] AppInfoPermissionsTabTest.RetainedFilePermissionsObtainedCorrectly (112 ms)
(Possibly because tsan uses libc++ instead of libstdc++?)
> Added collapsible permissions to the app info dialog
>
> Separated the optional and required permissions in the dialog, and
> added retained files as well. Also made the various types of
> permissions collapsible, and added a message when the app has no
> permissions whatsoever.
>
> BUG=356985, 350746
>
> Review URL: https://codereview.chromium.org/214163002
TBR=sashab@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266572
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|