Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 258083002: Revert 266518 "Added collapsible permissions to the app info dialog" (Closed)

Created:
6 years, 7 months ago by Nico
Modified:
6 years, 7 months ago
Reviewers:
sashab
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 266518 "Added collapsible permissions to the app info dialog" Test doesn't work with tsan: http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28TSan%20v2%29%281%29/builds/8850/steps/unit_tests/logs/RetainedFilePermissionsObtainedCorrectly [ RUN ] AppInfoPermissionsTabTest.RetainedFilePermissionsObtainedCorrectly ../../chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc:193: Failure Value of: retained_files[0] Actual: 24-byte object \u003C14-66 69-6C 65-5F 33-2E 65-78 74-00 0C-7D 00-00 2B-00 00-00 00-00 00-00> Expected: base::FilePath("file_1.ext") Which is: 24-byte object \u003C14-66 69-6C 65-5F 31-2E 65-78 74-00 00-00 00-00 07-7A E9-08 02-00 00-00> [ FAILED ] AppInfoPermissionsTabTest.RetainedFilePermissionsObtainedCorrectly (112 ms) (Possibly because tsan uses libc++ instead of libstdc++?) > Added collapsible permissions to the app info dialog > > Separated the optional and required permissions in the dialog, and > added retained files as well. Also made the various types of > permissions collapsible, and added a message when the app has no > permissions whatsoever. > > BUG=356985, 350746 > > Review URL: https://codereview.chromium.org/214163002 TBR=sashab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266572

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -620 lines) Patch
M trunk/src/chrome/app/generated_resources.grd View 1 chunk +0 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.h View 2 chunks +0 lines, -28 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab.cc View 2 chunks +70 lines, -373 lines 0 comments Download
D trunk/src/chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc View 1 chunk +0 lines, -206 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
6 years, 7 months ago (2014-04-28 15:15:22 UTC) #1
Nico
6 years, 7 months ago (2014-04-28 15:15:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r266572 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698