Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 2580793004: service worker: Add CHECKs for investigating null http info bug. (Closed)
Patch Set: Fix foreign fetch Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc
index b1d1174eeb220492f8130a36d6b4e07270c77341..72740fb0202a69a6b26c89eca6619b2417dd4a4c 100644
--- a/content/browser/service_worker/service_worker_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_job_unittest.cc
@@ -864,12 +864,16 @@ class UpdateJobTestHelper
WriteStringResponse(storage(), resource_id, kMockScriptBody);
version->script_cache_map()->NotifyFinishedCaching(
script, kMockScriptSize, net::OK, std::string());
+ version->SetMainScriptHttpResponseInfo(
+ EmbeddedWorkerTestHelper::CreateHttpResponseInfo());
} else {
if (script.GetOrigin() == kNoChangeOrigin) {
// Simulate fetching the updated script and finding it's identical to
// the incumbent.
version->script_cache_map()->NotifyFinishedCaching(
script, kMockScriptSize, net::ERR_FILE_EXISTS, std::string());
+ version->SetMainScriptHttpResponseInfo(
+ EmbeddedWorkerTestHelper::CreateHttpResponseInfo());
SimulateWorkerScriptLoaded(embedded_worker_id);
return;
}
@@ -878,6 +882,8 @@ class UpdateJobTestHelper
WriteStringResponse(storage(), resource_id, "mock_different_script");
version->script_cache_map()->NotifyFinishedCaching(
script, kMockScriptSize, net::OK, std::string());
+ version->SetMainScriptHttpResponseInfo(
+ EmbeddedWorkerTestHelper::CreateHttpResponseInfo());
}
EmbeddedWorkerTestHelper::OnStartWorker(

Powered by Google App Engine
This is Rietveld 408576698