Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: PRESUBMIT.py

Issue 2580793003: Remove stl_util's deletion functions. (Closed)
Patch Set: rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | base/stl_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Top-level presubmit script for Chromium. 5 """Top-level presubmit script for Chromium.
6 6
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
8 for more details about the presubmit API built into depot_tools. 8 for more details about the presubmit API built into depot_tools.
9 """ 9 """
10 10
(...skipping 289 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 ), 300 ),
301 ), 301 ),
302 ( 302 (
303 '#pragma comment(lib,', 303 '#pragma comment(lib,',
304 ( 304 (
305 'Specify libraries to link with in build files and not in the source.', 305 'Specify libraries to link with in build files and not in the source.',
306 ), 306 ),
307 True, 307 True,
308 (), 308 (),
309 ), 309 ),
310 (
311 r'STLDeleteValues', # http://crbug.com/555865
312 (
313 'This call is obsolete with C++ 11; create a map with owning',
314 'pointers instead (e.g. std::map<std::string, std::unique_ptr<x>> ).',
315 ),
316 True,
317 (),
318 ),
319 ) 310 )
320 311
321 312
322 _IPC_ENUM_TRAITS_DEPRECATED = ( 313 _IPC_ENUM_TRAITS_DEPRECATED = (
323 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n' 314 'You are using IPC_ENUM_TRAITS() in your code. It has been deprecated.\n'
324 'See http://www.chromium.org/Home/chromium-security/education/security-tips- for-ipc') 315 'See http://www.chromium.org/Home/chromium-security/education/security-tips- for-ipc')
325 316
326 317
327 _VALID_OS_MACROS = ( 318 _VALID_OS_MACROS = (
328 # Please keep sorted. 319 # Please keep sorted.
(...skipping 1977 matching lines...) Expand 10 before | Expand all | Expand 10 after
2306 results.extend(input_api.canned_checks.CheckTreeIsOpen( 2297 results.extend(input_api.canned_checks.CheckTreeIsOpen(
2307 input_api, 2298 input_api,
2308 output_api, 2299 output_api,
2309 json_url='http://chromium-status.appspot.com/current?format=json')) 2300 json_url='http://chromium-status.appspot.com/current?format=json'))
2310 2301
2311 results.extend(input_api.canned_checks.CheckChangeHasBugField( 2302 results.extend(input_api.canned_checks.CheckChangeHasBugField(
2312 input_api, output_api)) 2303 input_api, output_api))
2313 results.extend(input_api.canned_checks.CheckChangeHasDescription( 2304 results.extend(input_api.canned_checks.CheckChangeHasDescription(
2314 input_api, output_api)) 2305 input_api, output_api))
2315 return results 2306 return results
OLDNEW
« no previous file with comments | « no previous file | base/stl_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698